Differential D31995
xen/intr: add check for intr_register_source() errors Authored by ehem_freebsd_m5p.com on Sep 16 2021, 10:53 PM. Tags None Referenced Files
Subscribers
Details While unusual, intr_register_source() can return failure. A likely This also covers the condition identified by the KASSERT(), so remove
Diff Detail
Event TimelineComment Actions This really doesn't fit with D30743. This one is checking for this one situation which should never occur, but reality is perverse. Most likely trigger is intr_register_source() does a check for intr_lookup_source(vector) and will return EEXIST for the situation identical to the KASSERT(). This though would require something else to grab an interrupt from the Xen code's range; which in turn shouldn't happen. Comment Actions This doesn't work as part of D30743, since this isn't focused on xen_intr_port_to_isrc[]. This is simply a check which is really needed. Isn't needed as part of the Xen/ARM64 project, just my entire patch series includes this. This shouldn't occur, but safety checks are for the conditions we don't expect to occur. Comment Actions Looks fine to me. I would suggest keeping the KASSERT though, it is free and makes the point of failure more obvious if this condition did occur. Comment Actions On review, at HEAD the logic is inverted. When returning with NULL, the lock needs to be held. Updating to match actual situation. Comment Actions Updating due to concern which arose. If this occurs another spot will need to deal with it. OTOH should this in fact be a panic() since it shouldn't occur? |
Style, switch and case keyword on same line.