Page MenuHomeFreeBSD

ufs: Avoid subobject overflow in snapshot expunge code
ClosedPublic

Authored by jrtc27 on Dec 24 2021, 4:08 PM.
Tags
None
Referenced Files
F151526319: D33651.diff
Thu, Apr 9, 12:49 AM
Unknown Object (File)
Wed, Apr 8, 7:19 AM
Unknown Object (File)
Wed, Apr 8, 2:50 AM
Unknown Object (File)
Tue, Apr 7, 2:25 PM
Unknown Object (File)
Thu, Mar 19, 3:41 AM
Unknown Object (File)
Wed, Mar 18, 5:27 AM
Unknown Object (File)
Sat, Mar 14, 3:50 PM
Unknown Object (File)
Sat, Mar 14, 3:44 AM
Subscribers

Details

Summary

The code here tries to be smart and zeroes out both di_db and di_ib with
a single bzero call, thereby overrunning the di_db subobject. This is
fine on most architectures, if a little dodgy. However, on CHERI, the
compiler can optionally restrict the bounds on pointers to subobjects to
just that subobject, in order to mitigate intra-object buffer overflows,
and this is enabled in CheriBSD's pure-capability kernels.

Instead, use separate bzero calls for each array, and let the compiler
optimise it as it sees fit; even if it's not generating inline zeroing
code, Clang will happily optimise two consecutive bzero's to a single
larger call.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable