Page MenuHomeFreeBSD
Differential D33375

Improve extents verification logic
ClosedPublic
Actions

Authored by fsu on Dec 10 2021, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 2, 5:31 AM
Unknown Object (File)
Sun, Aug 2, 4:43 AM
Unknown Object (File)
Sat, Aug 1, 12:24 PM
Unknown Object (File)
Sat, Aug 1, 5:55 AM
Unknown Object (File)
Fri, Jul 31, 1:15 AM
Unknown Object (File)
Sat, Jul 18, 3:45 AM
Unknown Object (File)
Jul 4 2026, 10:16 PM
Unknown Object (File)
Jul 2 2026, 3:31 AM
View All Files
Subscribers
imp

Details

Reviewers
pfg
nc
Commits
rGf1d5e2c862ef: Improve extents verification logic
Summary

Add functionality for extents validation inside the filesystem extents block.
The main logic is implemented under ext4_validate_extent_entries() function, which verifies extents or extents indexes depending of extent depth value.

This PR is more robust fix for issue introduced in:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259112

Test Plan

Tested using next testing scripts:
https://github.com/thedrgreenthumb/Jenkins/tree/pjenkins/Target/ext2fs_test_all

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fsu created this revision.Dec 10 2021, 5:23 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 10 2021, 5:23 PM
fsu requested review of this revision.Dec 10 2021, 5:23 PM
pfg accepted this revision.Dec 11 2021, 12:37 AM
This revision is now accepted and ready to land.Dec 11 2021, 12:37 AM
Closed by commit rGf1d5e2c862ef: Improve extents verification logic (authored by fsu). · Explain WhyDec 30 2021, 6:15 AM
This revision was automatically updated to reflect the committed changes.
fsu added a commit: rGf1d5e2c862ef: Improve extents verification logic.

Revision Contents
Changeset List

PathSize
sys/
fs/
ext2fs/
291 lines
8 lines

Diff 100747

View Options

sys/fs/ext2fs/ext2_extents.c

Loading...
View Options

sys/fs/ext2fs/ext2_inode_cnv.c

Loading...