vfs_mountroot: Skip first 'Root mount waiting'
ClosedPublic
Actions

Authored by cperciva on Dec 20 2021, 7:34 PM.

Details

Reviewers: None
Commits: rGd4724934f2e4: vfs_mountroot: Skip 'Root mount waiting' < 1 s
rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s

Summary

While the message is technically correct, it's not particularly
helpful in the case where we're only waiting a few ms. This case
occurs frequently on EC2 arm64 instances with CAM initialization
racing to release its root hold before vfs_mountroot reaches this
point.

Sponsored by: https://www.patreon.com/cperciva

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43507
Build 40395: arc lint + arc unit

Event Timeline

cperciva created this revision.Dec 20 2021, 7:34 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2021, 7:34 PM

cperciva requested review of this revision.Dec 20 2021, 7:34 PM

Harbormaster completed remote builds in B43507: Diff 100366.Dec 20 2021, 7:34 PM

cperciva added a child revision: D33592: vfs_mountroot: Wait for GEOM idle post root holds.Dec 20 2021, 7:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2021, 8:41 PM

Closed by commit rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s.

cperciva added a commit: rGd4724934f2e4: vfs_mountroot: Skip 'Root mount waiting' < 1 s.Jan 12 2022, 7:31 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_mountroot.c

1 line

Diff 100366

View Options

sys/kern/vfs_mountroot.c

Context not available.
	*/	*/
	arm_smccc_1_0 hvc	arm_smccc_1_0 hvc
	arm_smccc_1_0 smc	arm_smccc_1_0 smc
		/* arm_smccc_1_2_hvc(const struct arm_smccc_1_2_regs *args,
		struct arm_smccc_1_2_regs res) /
		andrewUnsubmitted Done Inline Actions You can remove this comment & replace it with a newline to seperate the above from the 1.2 macro. andrew: You can remove this comment & replace it with a newline to seperate the above from the 1.2…
		.macro arm_smccc_1_2 insn
		ENTRY(arm_smccc_1_2_\insn)
		stp x1, x19, [sp, #-16]!
		mov x19, x0
		ldp x0, x1, [x19, #16 * 0]
		ldp x2, x3, [x19, #16 * 1]
		ldp x4, x5, [x19, #16 * 2]
		ldp x6, x7, [x19, #16 * 3]
		ldp x8, x9, [x19, #16 * 4]
		andrewUnsubmitted Done Inline Actions Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so we can also add `smc` support. andrew: Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so…
		ldp x10, x11, [x19, #16 * 5]
		ldp x12, x13, [x19, #16 * 6]
		ldp x14, x15, [x19, #16 * 7]
		ldp x16, x17, [x19, #16 * 8]
		hvc #0
		andrewUnsubmitted Done Inline Actions `\insn #0` andrew: `\insn #0`
		ldr x19, [sp]
		cbz x19, 1f
		stp x0, x1, [x19, #16 * 0]
		stp x2, x3, [x19, #16 * 1]
		lwhsuUnsubmitted Done Inline Actions Why two spaces between `,` and `[`? for those 3 lines? lwhsu: Why two spaces between `,` and `[`? for those 3 lines?
		stp x4, x5, [x19, #16 * 2]
		stp x6, x7, [x19, #16 * 3]
		stp x8, x9, [x19, #16 * 4]
		stp x10, x11, [x19, #16 * 5]
		stp x12, x13, [x19, #16 * 6]
		stp x14, x15, [x19, #16 * 7]
		stp x16, x17, [x19, #16 * 8]
		ldp xzr, x19, [sp], #16
		1: ret
		END(arm_smccc_1_2\insn)
		.endm
		/* int arm_smccc_1_2_(const struct arm_smccc_1_2_regs args,
		lwhsuUnsubmitted Done Inline Actions Also those 3 lines. lwhsu: Also those 3 lines.
		lwhsuUnsubmitted Not Done Inline Actions Small nit: trailing white space. lwhsu: Small nit: trailing white space.
		* struct arm_smccc_1_2_regs *res)
		*/
		arm_smccc_1_2 hvc
		arm_smccc_1_2 smc
Context not available.

vfs_mountroot: Skip first 'Root mount waiting'ClosedPublicActions