Differential D33591

vfs_mountroot: Skip first 'Root mount waiting'
ClosedPublic
Actions

Authored by cperciva on Dec 20 2021, 7:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 1, 12:52 AM

	Unknown Object (File)
	Mon, Dec 1, 12:52 AM

	Unknown Object (File)
	Fri, Nov 28, 9:45 AM

	Unknown Object (File)
	Sun, Nov 23, 5:22 PM

	Unknown Object (File)
	Sat, Nov 22, 4:45 PM

	Unknown Object (File)
	Sat, Nov 15, 3:41 PM

	Unknown Object (File)
	Fri, Nov 14, 6:49 PM

	Unknown Object (File)
	Fri, Nov 14, 11:45 AM

View All 96 Files

Subscribers

Details

Reviewers: None
Commits: rGd4724934f2e4: vfs_mountroot: Skip 'Root mount waiting' < 1 s
rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s

Summary

While the message is technically correct, it's not particularly
helpful in the case where we're only waiting a few ms. This case
occurs frequently on EC2 arm64 instances with CAM initialization
racing to release its root hold before vfs_mountroot reaches this
point.

Sponsored by: https://www.patreon.com/cperciva

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Dec 20 2021, 7:34 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2021, 7:34 PM

cperciva requested review of this revision.Dec 20 2021, 7:34 PM

Harbormaster completed remote builds in B43507: Diff 100366.Dec 20 2021, 7:34 PM

cperciva added a child revision: D33592: vfs_mountroot: Wait for GEOM idle post root holds.Dec 20 2021, 7:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2021, 8:41 PM

Closed by commit rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGe6db5eb9ec7b: vfs_mountroot: Skip 'Root mount waiting' < 1 s.

cperciva added a commit: rGd4724934f2e4: vfs_mountroot: Skip 'Root mount waiting' < 1 s.Jan 12 2022, 7:31 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_mountroot.c

1 line

Diff 100718

sys/kern/vfs_mountroot.c

Loading...