Differential D33330

bsdinstall: bootconfig: Try to clean old efi boot entries
ClosedPublic
Actions

Authored by manu on Dec 8 2021, 9:41 AM.

Tags

None

Referenced Files

	F166680661: D33330.id99697.diff
	Sat, Aug 15, 12:18 PM

	F166615221: D33330.id100066.diff
	Fri, Aug 14, 9:30 PM

	F166615207: D33330.id99696.diff
	Fri, Aug 14, 9:30 PM

	F166615200: D33330.id99697.diff
	Fri, Aug 14, 9:30 PM

	F166615000: D33330.diff
	Fri, Aug 14, 9:28 PM

	Unknown Object (File)
	Wed, Aug 12, 10:00 PM

	Unknown Object (File)
	Wed, Aug 12, 4:50 PM

	Unknown Object (File)
	Wed, Aug 12, 4:22 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

imp
bapt

Group Reviewers

Commits

rG477fbe6732fe: bsdinstall: bootconfig: Try to clean old efi boot entries
rG40c928e7b80a: bsdinstall: bootconfig: Try to clean old efi boot entries

Summary

If one install FreeBSD on the same machine multiple times in a row or
on different harddrive they have a lot of 'FreeBSD' efi boot entries added.
With this patch we now do :

If there is no 'FreeBSD' entry we add one like before
If there is one or more entries we ask the user if they want to delete them all and add a new one
- If they say yes we do that
- If they say no we prompt them an inputbox so they can enter a different entry name if they want, it defaults to 'FreeBSD'

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Dec 8 2021, 9:41 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptDec 8 2021, 9:41 AM

manu requested review of this revision.Dec 8 2021, 9:41 AM

Harbormaster completed remote builds in B43226: Diff 99696.Dec 8 2021, 9:41 AM

manu added reviewers: imp, releng.Dec 8 2021, 9:41 AM

bapt requested changes to this revision.Dec 8 2021, 9:45 AM

bapt added a subscriber: bapt.

bapt added inline comments.

usr.sbin/bsdinstall/scripts/bootconfig
68	efibootmgr \| grep -c 'FreeBSD$'
76	$DIALOG ?

This revision now requires changes to proceed.Dec 8 2021, 9:45 AM

Address bapt's comments.

Harbormaster completed remote builds in B43227: Diff 99697.Dec 8 2021, 9:49 AM

manu marked 2 inline comments as done.Dec 8 2021, 9:50 AM

bapt accepted this revision.Dec 8 2021, 9:50 AM

This revision is now accepted and ready to land.Dec 8 2021, 9:50 AM

corvink added a subscriber: corvink.Dec 8 2021, 11:58 AM

@imp are you ok with this ?

This ticks all my boxes. It's optional, it prompts the user, and it appears to do the right sort of things to manage the list.

Closed by commit rG40c928e7b80a: bsdinstall: bootconfig: Try to clean old efi boot entries (authored by manu). · Explain WhyDec 15 2021, 2:24 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG40c928e7b80a: bsdinstall: bootconfig: Try to clean old efi boot entries.

manu added a commit: rG477fbe6732fe: bsdinstall: bootconfig: Try to clean old efi boot entries.Dec 30 2021, 9:10 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

scripts/

54 lines

Diff 100066

usr.sbin/bsdinstall/scripts/bootconfig

Loading...