HomeFreeBSD

Expose clang's alignment builtins and use them for roundup2/rounddown2

Description

Expose clang's alignment builtins and use them for roundup2/rounddown2

This makes roundup2/rounddown2 type- and const-preserving and allows
using it on pointer types without casting to uintptr_t first. Not
performing pointer-to-integer conversions also helps the compiler's
optimization passes and can therefore result in better code generation.
When using it with integer values there should be no change other than
the compiler checking that the alignment value is a valid power-of-two.

I originally implemented these builtins for CHERI a few years ago and
they have been very useful for CheriBSD. However, they are also useful
for non-CHERI code so I was able to upstream them for Clang 10.0.

Rationale from the clang documentation:
Clang provides builtins to support checking and adjusting alignment
of pointers and integers. These builtins can be used to avoid relying
on implementation-defined behavior of arithmetic on integers derived
from pointers. Additionally, these builtins retain type information
and, unlike bitwise arithmetic, they can perform semantic checking on
the alignment value.

There is also a feature request for GCC, so GCC may also support it in
the future: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98641

Reviewed By: brooks, jhb, imp
Differential Revision: https://reviews.freebsd.org/D28332

(cherry picked from commit 8fa6abb6f4f64f4f23e2920e2aea7996566851a4)

Details

Provenance
arichardsonAuthored on Feb 3 2021, 3:27 PM
dimCommitted on Aug 31 2021, 7:24 PM
Reviewer
brooks
Differential Revision
D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2
Parents
R10:bfa89a5dd105: iflib: fix potential NULL dereference
Branches
Unknown
Tags
Unknown