Page MenuHomeFreeBSD

Move SET_LATE_CONFIGURE_ARGS into a script to reduce executions.
Needs ReviewPublic

Authored by bdrewery on Mar 9 2017, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 31 2024, 4:28 PM
Unknown Object (File)
Mar 30 2024, 2:07 AM
Unknown Object (File)
Mar 28 2024, 5:53 AM
Unknown Object (File)
Feb 21 2024, 8:14 PM
Unknown Object (File)
Jan 1 2024, 4:49 AM
Unknown Object (File)
Dec 25 2023, 12:17 PM
Unknown Object (File)
Dec 17 2023, 3:57 AM
Unknown Object (File)
Nov 2 2023, 1:54 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Summary

The goal of this is to only run './configure --help' once, rather than
N times for each option we're looking for.

While here I noticed that the --build support for >autoconf-2.13 from
r218938 and r219124 was not quite right. This requires further
investigation and a separate fix.

This also includes --enable-jobserver which has an EXP-RUN request
at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217670

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9968
Build 10400: arc lint + arc unit

Event Timeline

Fix build with ports not using GNU_CONFIGURE but with HAVE_CONFIGURE, like perl. They don't set the _LATE_CONFIGURE_ARGS so the ';' have to move back.

antoine added inline comments.
Mk/Scripts/set-late-configure-args.sh
43

with --verison, but with --version?

here it says:

% ./configure --version
configure generated by autoconf version 2.13

45

with --verison, but with --version??

Remove bogus comment due to typo in testing.

Mk/Scripts/set-late-configure-args.sh
26

So, we can see where you copied that from, should be DEBUG_MK_SCRIPTS_LATE_CONFIGURE_ARGS or something similar :)

32

empty line?

48

Mmm, maybe quote "${dp_CONFIGURE_CMD}" in there, in case there is space or something in there.

78

same here ?

bdrewery marked 4 inline comments as done.

Review findings