usr.bin/xlint: convert to SRCTOP idioms
AbandonedPublic
Actions

Authored by ngie on Mar 6 2017, 8:20 PM.

Details

Reviewers

Summary

usr.bin/xlint: convert to SRCTOP idioms

The former idioms used were .CURDIR-relative paths. Using SRCTOP (as
discussed previously), makes pathing more intuitive, abbreviates make
output by resolving relative paths absolute to the top of the source
tree, makes portions of the tree relocatable/forkable, etc.

Use XLINT_SRC to refer to ${SRCTOP}/usr.bin/xlint in a shorthand manner.

MFC after: 1 month
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7929
Build 8066: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 26040.Mar 6 2017, 8:20 PM

ngie retitled this revision from to usr.bin/xlint: convert to SRCTOP idioms.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added subscribers: bdrewery, imp.

bdrewery requested changes to this revision.Mar 7 2017, 7:38 PM

bdrewery added a reviewer: bdrewery.

bdrewery added inline comments.

usr.bin/xlint/lint1/Makefile
16	Where is XLINT_SRC defined by this point? This looks like it needs to move below the .include <bsd.prog.mk> or another include is needed to bring in ../Makefile.inc
usr.bin/xlint/lint2/Makefile
4	Same problem here
usr.bin/xlint/xlint/Makefile
4	Same problem here

This revision now requires changes to proceed.Mar 7 2017, 7:38 PM

Abandoning revision since I will not be working on the build system proper anymore, apart from test integration or any components that directly correlate with testing.