Page MenuHomeFreeBSD

usr.bin/svn: convert to OBJTOP/SRCTOP idioms
AbandonedPublic

Authored by ngie on Mar 6 2017, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 6:50 AM
Unknown Object (File)
Jan 14 2024, 9:17 PM
Unknown Object (File)
Nov 10 2023, 11:36 AM
Unknown Object (File)
Nov 10 2023, 1:50 AM
Unknown Object (File)
Nov 7 2023, 11:19 AM
Unknown Object (File)
Nov 6 2023, 7:28 PM
Unknown Object (File)
Nov 5 2023, 11:16 AM
Unknown Object (File)
Oct 24 2023, 9:50 AM
Subscribers

Details

Reviewers
bdrewery
Summary

usr.bin/svn: convert to OBJTOP/SRCTOP idioms

The former idioms used were .CURDIR/.OBJDIR-relative paths.

Using OBJTOP/SRCTOP (as discussed previously), makes bathing more
intuitive, abbreviates make output by resolving relative paths
absolute to the top of the source tree, makes portions of the tree
relocatable/forkable, etc.

Use SVN_OBJ and SVN_SRC to parameterize out OBJTOP/usr.bin/svn and
SRCTOP/usr.bin/svn, respectively.

MFC after: 1 month
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7931
Build 8068: arc lint + arc unit

Event Timeline

ngie retitled this revision from to usr.bin/svn: convert to SRCTOP idioms.
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie added subscribers: bdrewery, imp.

Parameterize ${SRCTOP} and ${OBJTOP} relative paths to usr.bin/svn so this
directory tree can be further relocated if need be, in a much simpler way

ngie retitled this revision from usr.bin/svn: convert to SRCTOP idioms to usr.bin/svn: convert to OBJTOP/SRCTOP idioms.Mar 6 2017, 8:21 PM
ngie updated this object.

Add some previously missed Makefiles

bdrewery requested changes to this revision.Mar 7 2017, 7:36 PM
bdrewery added a reviewer: bdrewery.
bdrewery added inline comments.
usr.bin/svn/Makefile.inc
16–23

The usr.bin/Makefile.inc is now included less often. See usr.bin/svn/lib/Makefile.inc. If SVNDIR is not set, it then sets SVNDIR, then includes this file. Thus this line will never trigger since it is blocked by !defined(SVNDIR).

cd usr.bin/svn/lib/libserf && make -V BIN_DIR

Side note, it would be nicer if Makefile.inc changes were not bundled with .OBJDIR/CURDIR:H changes.

This revision now requires changes to proceed.Mar 7 2017, 7:36 PM

Abandoning revision since I will not be working on the build system proper anymore, apart from test integration or any components that directly correlate with testing.