Fix a memory leak in ppp
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 2 2017, 1:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 4, 6:02 AM

	Unknown Object (File)
	Tue, Aug 4, 5:56 AM

	Unknown Object (File)
	Tue, Jul 21, 8:53 PM

	Unknown Object (File)
	Sat, Jul 11, 2:51 PM

	Unknown Object (File)
	Mon, Jul 6, 11:47 PM

	Unknown Object (File)
	Jul 5 2026, 11:22 PM

	Unknown Object (File)
	Jul 5 2026, 5:41 AM

	Unknown Object (File)
	Jul 4 2026, 11:02 AM

View All Files

Subscribers

imp

Details

Reviewers

stevek

Commits

rS319638: Before returning because of an memory allocation error, free the memory

Summary

ppp iface.c
Before returning because of an memory allocation error, free the memory already allocated to buf.

Test Plan

Run clang's static analyzer, scan-build, to find the problem and to show it is resolved.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25855.Mar 2 2017, 1:41 AM

trix_juniper.net retitled this revision from to Fix a memory leak in ppp.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added a reviewer: stevek.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMar 2 2017, 1:41 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Mar 2 2017, 10:39 PM

Closed by commit rS319638: Before returning because of an memory allocation error, free the memory (authored by stevek). · Explain WhyJun 6 2017, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

ppp/

iface.c

1 line

Diff 29286

View Options

Fix a memory leak in pppClosedPublicActions