Implement __cxa_throw_bad_array_new_length this is required to build world with g++ 4.9
powered by: I_have_no_idea_of_what_I_am_doing
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Please can you submit the fixed version of this as a pull request upstream too, and I'll approve it there so that we don't have more pain merging the next time.
contrib/libcxxrt/auxhelper.cc | ||
---|---|---|
79 ↗ | (On Diff #2070) | Please keep brace style consistent with the rest of the codebase. Also, (void) should be (). |
contrib/libcxxrt/stdexcept.h | ||
91 ↗ | (On Diff #2070) | I don't see the implementation of any of the methods declared here. |
lib/libcxxrt/Version.map | ||
29 ↗ | (On Diff #2070) | I think you also want the symbols for the bad_array_new_length class (especially the typeid stuff) or you won't be able to dynamic_cast<> it or catch (std::bad_array_new_length). |
Comment Actions
Told you I don't understand what I am doing here :)
Anyway I tried to address all your comments
I also created a pull request on upstream:
https://github.com/pathscale/libcxxrt/pull/23