Page MenuHomeFreeBSD

Fix a memory leak in newfs_msdos
Needs ReviewPublic

Authored by trix_juniper.net on Feb 20 2017, 4:36 PM.

Details

Reviewers
imp
stevek
Summary

When the input file is not a path, memory is allocated and reassigned to the variable 'fname' and never freed.

Track this use case with the new variable 'local_fname' and free the memory after its use. The fname qualify 'const' is removed because the variable really isn't const and scan-build complains of use of const with free. The variable 'ret' introduced to hold the return status of mkfs_msdos() so fname could be freed.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problem; run scan-build after to show problem is resolved.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

trix_juniper.net retitled this revision from to Fix a memory leak in newfs_msdos.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, imp.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository.