Make the code match the comments. If we have ANY buf's that failed then return EAGAIN. The current code just returns that if the LAST buf failed.
ClosedPublic
Actions

Authored by imp on Feb 19 2017, 7:09 PM.

Details

Reviewers

kib
trasz

Commits

rS314053: Make the code match the comments: If we have ANY buf's that failed

Summary

This code just appears to be wrong. Logically, it makes more sense to
do what the comments say.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp updated this revision to Diff 25388.Feb 19 2017, 7:09 PM

imp retitled this revision from to Make the code match the comments. If we have ANY buf's that failed then return EAGAIN. The current code just returns that if the LAST buf failed..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added reviewers: kib, trasz.

kib accepted this revision.Feb 19 2017, 8:30 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Feb 19 2017, 8:30 PM

My worry here is that with this patch, we won't retry fsync if it failed with EIO, while with the previous code, due to the logic error, we would (at least if the failed buf was not the last one). I'm not sure if anything depends on it, though.

I'd say go for it. We can improve the semantics later, and this is an obvious bug fix.

Closed by commit rS314053: Make the code match the comments: If we have ANY buf's that failed (authored by imp). · Explain WhyFeb 21 2017, 6:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_default.c

4 lines

Diff 25490

View Options

head/sys/kern/vfs_default.c

Make the code match the comments. If we have ANY buf's that failed then return EAGAIN. The current code just returns that if the LAST buf failed.ClosedPublicActions