Page MenuHomeFreeBSD

Fix scfb to only attach the device if it can drive it.
ClosedPublic

Authored by rezny on Feb 16 2017, 11:33 AM.

Details

Summary

This is a fix to allow fallback to vesa to work correctly. scfb is probed before vesa so that it will be used on PCs with UEFI, but scfb would always claim the device during Probe so vesa sees no device during Probe, meaning the X server bails on PCs with traditional BIOS instead oF using vesa. This patch adds a check for a framebuffer in Probe (copied from PreInit) before claiming the PCI device so. Also, assign the port to x11@ after discussion with ray@ on IRC. x11@ should take over maintenance of scfb itself as well.

Test Plan

verified fallback to vesa now works on 11 amd64, verified scfb (using ofwfb) still works on 11 ppc64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rezny updated this revision to Diff 25263.Feb 16 2017, 11:33 AM
rezny retitled this revision from to Fix scfb to only attach the device if it can drive it..
rezny updated this object.
rezny edited the test plan for this revision. (Show Details)
rezny added reviewers: x11, swills, feld.
swills accepted this revision.Feb 16 2017, 2:23 PM
swills edited edge metadata.

Approved

This revision is now accepted and ready to land.Feb 16 2017, 2:23 PM
This revision was automatically updated to reflect the committed changes.