Page MenuHomeFreeBSD

net/py-python-bitcoinrpc: Update to 1.0
ClosedPublic

Authored by loader on Feb 12 2017, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 10 2024, 4:48 PM
Unknown Object (File)
Feb 24 2024, 1:47 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Unknown Object (File)
Feb 18 2024, 1:06 PM
Subscribers

Details

Summary

Proposed commit log message:

net/py-python-bitcoinrpc: Update to 1.0

- Switch MASTER_SITE to CHEESESHOP
- Add NO_ARCH
- Update LICENSE to LGPL21
- Add LICENSE_FILE
- Allow concurrent installation (USE_PYTHON=concurrent)

Reviewed_by: koobs, mat
Approved by: koobs (ports)
Submitted by: Gyver Def (gdef wp pl)
Differential_Revision: D9552
Test Plan
  • portlint: OK (looks fine)
  • testport: OK (poudriere: 1200060, [armv7, aarch64], '', [py27, py36] tested)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7372
Build 7537: arc lint + arc unit

Event Timeline

loader retitled this revision from to net/py-python-bitcoinrpc: update to 1.0.
loader updated this object.
loader edited the test plan for this revision. (Show Details)
loader added a reviewer: koobs.

% portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere log:
http://pastebin.com/raw/ne5fdScD

USES=python:2.7+ and USE_PYTHON=concurrent

loader edited the test plan for this revision. (Show Details)
koobs requested changes to this revision.May 31 2017, 9:27 AM
koobs added inline comments.
net/py-python-bitcoinrpc/Makefile
13

Add LICENSE_FILE (${WRKSRC}/LICENSE) where one exists in distfiles

23

Keep values sorted if they're already sorted

This revision now requires changes to proceed.May 31 2017, 9:27 AM

@loader Don't need to mention yourself in Submitted by: in commit log messages, as anything not explicitly referenced [1] is implied to be by you, as everyone else would be referenced already by name

koobs retitled this revision from net/py-python-bitcoinrpc: update to 1.0 to net/py-python-bitcoinrpc: Update to 1.0.May 31 2017, 9:47 AM
net/py-python-bitcoinrpc/Makefile
16–18

There is a v1.0 tag, so you should remove this and add a DISTVERSIONPREFIX=v in the top block.

Like always, if this does not correspond to the 1.0 tag, then it should not be named 1.0. Or maybe one should open an issue with upstream telling them that the v1.0 tag does not correspond to the 1.0 version.

loader edited edge metadata.

Add LICENSE_FILE and sort USE_PYTHON

Nice work, ship it!

Don't forget to remove underscores from commit log message properties :)

This revision is now accepted and ready to land.May 31 2017, 10:35 AM
loader edited edge metadata.

Add DISTVERSIONPREFIX=v

This revision now requires review to proceed.May 31 2017, 12:04 PM

Switch MASTER_SITE to CHEESESHOP

loader edited the test plan for this revision. (Show Details)
loader edited the test plan for this revision. (Show Details)

I would also note the license change in the commit log message

This revision is now accepted and ready to land.Mar 18 2018, 10:04 AM

@loader Revision already accepted, thanks for that commit log message update :)

This revision was automatically updated to reflect the committed changes.