Page MenuHomeFreeBSD
Differential D9536

prefix UFS symbols with UFS_ to reduce namespace pollution
ClosedPublic
Actions

Authored by emaste on Feb 11 2017, 4:46 AM.
Tags
None
Referenced Files
F160482375: D9536.diff
Wed, Jun 24, 11:39 PM
F160477461: D9536.id24996.diff
Wed, Jun 24, 10:21 PM
F160477098: D9536.id24996.diff
Wed, Jun 24, 10:16 PM
F160442344: D9536.diff
Wed, Jun 24, 11:43 AM
F160441992: D9536.diff
Wed, Jun 24, 11:37 AM
Unknown Object (File)
Thu, Jun 18, 1:10 PM
Unknown Object (File)
May 17 2026, 1:01 PM
Unknown Object (File)
May 17 2026, 2:48 AM
View All Files
Subscribers
siva

Details

Reviewers
kib
mckusick
Commits
rS313780: prefix UFS symbols with UFS_ to reduce namespace pollution
Summary

Specifically:

ROOTINO -> UFS_ROOTINO
WINO -> UFS_WINO
NXADDR -> UFS_NXADDR
NDADDR -> UFS_NDADDR
NIADDR -> UFS_NIADDR
MAXSYMLINKLEN_UFS[12] -> UFS[12]_MAXSYMLINKLEN (for consistency)

Prefix ext2's and nandfs's NDADDR and NIADDR with EXT2_ and NANDFS_

Obtained from: NetBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 24996.Feb 11 2017, 4:46 AM
emaste retitled this revision from to prefix UFS symbols with UFS_ to reduce namespace pollution.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, mckusick.
kib accepted this revision.Feb 11 2017, 1:34 PM
kib edited edge metadata.

What about I* symbols from ufs/dinode.h ?

This revision is now accepted and ready to land.Feb 11 2017, 1:34 PM
mckusick accepted this revision.Feb 15 2017, 6:57 AM
mckusick edited edge metadata.

This looks like a useful change and should have no effect on functionality.

emaste mentioned this in D9623: prefix (more) UFS symbols with UFS_ to reduce namespace pollution.Feb 15 2017, 7:54 PM
emaste added a subscriber: siva.Jun 2 2017, 8:18 PM
Closed by commit rS313780: prefix UFS symbols with UFS_ to reduce namespace pollution (authored by emaste). · Explain WhyJul 14 2017, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libstand/
46 lines
14 lines
40 lines
sbin/
dump/
37 lines
ffsinfo/
4 lines
fsck_ffs/
25 lines
6 lines
4 lines
44 lines
2 lines
24 lines
2 lines
39 lines
4 lines
2 lines
6 lines
35 lines
fsdb/
24 lines
8 lines
fsirand/
2 lines
growfs/
10 lines
2 lines
newfs/
31 lines
newfs_nandfs/
4 lines
quotacheck/
3 lines
restore/
6 lines
10 lines
6 lines
18 lines
20 lines
2 lines
2 lines
tunefs/
26 lines
sys/
boot/
common/
10 lines
fs/
ext2fs/
8 lines
6 lines
23 lines
27 lines
8 lines
8 lines
nandfs/
42 lines
8 lines
nfsclient/
2 lines
ufs/
ffs/
32 lines
40 lines
37 lines
90 lines
124 lines
4 lines
17 lines
8 lines
ufs/
22 lines
27 lines
12 lines
2 lines
4 lines
usr.sbin/
makefs/
16 lines
ffs/
4 lines
20 lines
17 lines
16 lines
4 lines
quot/
6 lines

Diff 30780

View Options

head/lib/libstand/ext2fs.c

Loading...
View Options

head/lib/libstand/nandfs.c

Loading...
View Options

head/lib/libstand/ufs.c

Loading...
View Options

head/sbin/dump/traverse.c

Loading...
View Options

head/sbin/ffsinfo/ffsinfo.c

Loading...
View Options

head/sbin/fsck_ffs/dir.c

Loading...
View Options

head/sbin/fsck_ffs/fsutil.c

Loading...
View Options

head/sbin/fsck_ffs/gjournal.c

Loading...
View Options

head/sbin/fsck_ffs/inode.c

Loading...
View Options

head/sbin/fsck_ffs/main.c

Loading...
View Options

head/sbin/fsck_ffs/pass1.c

Loading...
View Options

head/sbin/fsck_ffs/pass1b.c

Loading...
View Options

head/sbin/fsck_ffs/pass2.c

Loading...
View Options

head/sbin/fsck_ffs/pass3.c

Loading...
View Options

head/sbin/fsck_ffs/pass4.c

Loading...
View Options

head/sbin/fsck_ffs/pass5.c

Loading...
View Options

head/sbin/fsck_ffs/suj.c

Loading...
View Options

head/sbin/fsdb/fsdb.c

Loading...
View Options

head/sbin/fsdb/fsdbutil.c

Loading...
View Options

head/sbin/fsirand/fsirand.c

Loading...
View Options

head/sbin/growfs/debug.c

Loading...
View Options

head/sbin/growfs/growfs.c

Loading...
View Options

head/sbin/newfs/mkfs.c

Loading...
View Options

head/sbin/newfs_nandfs/newfs_nandfs.c

Loading...
View Options

head/sbin/quotacheck/quotacheck.c

Loading...
View Options

head/sbin/restore/dirs.c

Loading...
View Options

head/sbin/restore/interactive.c

Loading...
View Options

head/sbin/restore/main.c

Loading...
View Options

head/sbin/restore/restore.c

Loading...
View Options

head/sbin/restore/symtab.c

Loading...
View Options

head/sbin/restore/tape.c

Loading...
View Options

head/sbin/restore/utilities.c

Loading...
View Options

head/sbin/tunefs/tunefs.c

Loading...
View Options

head/sys/boot/common/ufsread.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_alloc.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_balloc.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_bmap.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_inode.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_inode_cnv.c

Loading...
View Options

head/sys/fs/ext2fs/inode.h

Loading...
View Options

head/sys/fs/nandfs/bmap.c

Loading...
View Options

head/sys/fs/nandfs/nandfs_fs.h

Loading...
View Options

head/sys/fs/nfsclient/nfs_clvfsops.c

Loading...
View Options

head/sys/ufs/ffs/ffs_alloc.c

Loading...
View Options

head/sys/ufs/ffs/ffs_balloc.c

Loading...
View Options

head/sys/ufs/ffs/ffs_inode.c

Loading...
View Options

head/sys/ufs/ffs/ffs_snapshot.c

Loading...
View Options

head/sys/ufs/ffs/ffs_softdep.c

Loading...
View Options

head/sys/ufs/ffs/ffs_vfsops.c

Loading...
View Options

head/sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

head/sys/ufs/ffs/fs.h

Loading...
View Options

head/sys/ufs/ufs/dinode.h

Loading...
View Options

head/sys/ufs/ufs/ufs_bmap.c

Loading...
View Options

head/sys/ufs/ufs/ufs_lookup.c

Loading...
View Options

head/sys/ufs/ufs/ufs_vfsops.c

Loading...
View Options

head/sys/ufs/ufs/ufs_vnops.c

Loading...
View Options

head/usr.sbin/makefs/ffs.c

Loading...
View Options

head/usr.sbin/makefs/ffs/ffs_alloc.c

Loading...
View Options

head/usr.sbin/makefs/ffs/ffs_balloc.c

Loading...
View Options

head/usr.sbin/makefs/ffs/mkfs.c

Loading...
View Options

head/usr.sbin/makefs/ffs/ufs_bmap.c

Loading...
View Options

head/usr.sbin/makefs/makefs.h

Loading...
View Options

head/usr.sbin/quot/quot.c

Loading...