Page MenuHomeFreeBSD

prefix UFS symbols with UFS_ to reduce namespace pollution
ClosedPublic

Authored by emaste on Feb 11 2017, 4:46 AM.

Details

Summary

Specifically:

ROOTINO -> UFS_ROOTINO
WINO -> UFS_WINO
NXADDR -> UFS_NXADDR
NDADDR -> UFS_NDADDR
NIADDR -> UFS_NIADDR
MAXSYMLINKLEN_UFS[12] -> UFS[12]_MAXSYMLINKLEN (for consistency)

Prefix ext2's and nandfs's NDADDR and NIADDR with EXT2_ and NANDFS_

Obtained from: NetBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste retitled this revision from to prefix UFS symbols with UFS_ to reduce namespace pollution.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, mckusick.
kib edited edge metadata.

What about I* symbols from ufs/dinode.h ?

This revision is now accepted and ready to land.Feb 11 2017, 1:34 PM
mckusick edited edge metadata.

This looks like a useful change and should have no effect on functionality.

This revision was automatically updated to reflect the committed changes.