localtime: return NULL if time_t out of range of struct tm
ClosedPublic
Actions

Authored by emaste on Feb 10 2017, 9:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 8:03 AM

	Unknown Object (File)
	Fri, Sep 11, 11:29 AM

	Unknown Object (File)
	Thu, Sep 10, 9:44 PM

	Unknown Object (File)
	Wed, Sep 9, 4:35 PM

	Unknown Object (File)
	Tue, Sep 8, 11:50 AM

	Unknown Object (File)
	Mon, Sep 7, 2:58 AM

	Unknown Object (File)
	Mon, Sep 7, 1:12 AM

	Unknown Object (File)
	Sun, Sep 6, 5:52 PM

View All Files

Subscribers

rafael.espindola_gmail.com

Details

Reviewers

bapt

Commits

rS313774: localtime: return NULL if time_t out of range of struct tm

Summary

Previously we would truncate tm.tm_year for time_ts corresponding to a year that does not fit in int.

This was fixed in tzcode in 2004 but has persisted in our tree rS2708.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

For reference, this broke the bash-static build with LLD: https://github.com/emaste/freebsd-ports/pull/20

bapt accepted this revision.Feb 12 2017, 5:44 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Feb 12 2017, 5:44 PM

Closed by commit rS313774: localtime: return NULL if time_t out of range of struct tm (authored by emaste). · Explain WhyFeb 15 2017, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

tzcode/

stdtime/

localtime.c

9 lines

Diff 25224

View Options

head/contrib/tzcode/stdtime/localtime.c

localtime: return NULL if time_t out of range of struct tmClosedPublicActions