Page MenuHomeFreeBSD

localtime: return NULL if time_t out of range of struct tm
ClosedPublic

Authored by emaste on Feb 10 2017, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:28 PM
Unknown Object (File)
Thu, Oct 9, 6:29 AM
Unknown Object (File)
Fri, Sep 19, 10:44 AM
Unknown Object (File)
Sep 14 2025, 8:26 AM
Unknown Object (File)
Sep 13 2025, 11:30 PM
Unknown Object (File)
Sep 12 2025, 2:16 AM
Unknown Object (File)
Sep 9 2025, 7:47 AM
Unknown Object (File)
Aug 15 2025, 6:54 AM

Details

Summary

Previously we would truncate tm.tm_year for time_ts corresponding to a year that does not fit in int.

This was fixed in tzcode in 2004 but has persisted in our tree rS2708.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to localtime: return NULL if time_t out of range of struct tm.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: bapt.
emaste added a subscriber: rafael.espindola_gmail.com.

For reference, this broke the bash-static build with LLD: https://github.com/emaste/freebsd-ports/pull/20

bapt edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.