Page MenuHomeFreeBSD

update sysutils/mcelog to 148
ClosedPublic

Authored by lifanov on Feb 5 2017, 4:48 PM.

Details

Summary
update sysutils/mcelog to 148

 - Intel Xeons from Ivy Bridge onwards support a processor identification number.
 - Fix warning with gcc 6.x
 - Makefile: Make `git` check portable (POSIX compatible)
 - replace asprintf with xasprintf as per memutil.c
 - Return -ENOMEM for vasprintf in sysfs_write

 PR: 216789
 Submitted by: ultima1252@gmail.com (maintainer)
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential Revision: https://reviews.freebsd.org/DXXXX
Test Plan

poudriere testport - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lifanov retitled this revision from to update sysutils/mcelog to 148.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added a reviewer: matthew.
lifanov added a subscriber: koobs.
sysutils/mcelog/files/patch-Makefile
6 ↗(On Diff #24771)

You shouldn't assume that ${PREFIX} is /usr/local here.

The best practice here is to substitute in a placeholder eg %PREFIX% via
patch-Makefile and then use a ${REINPLACE_CMD} call in post-patch: to replace
that with the current value of ${PREFIX}.

This is easily broken and needs to be checked when preparing updates, because
make makepatch will regenerate patches based on the state of ${WRKDIR} after
the post-patch: target has run, which unfortunately results in blowing away the
placeholder from the patch files.

sysutils/mcelog/files/patch-Makefile
6 ↗(On Diff #24771)

Best would probably be to add prefix=${PREFIX} to MAKE_ARGS.

o fix PREFIX
o fix potentially-different package if user has git installed

addressed hardcoded PREFIX

This revision is now accepted and ready to land.Feb 6 2017, 3:19 PM
lifanov edited edge metadata.

whoops, delete unneeded part of the Makefile patch - moved to port Makefile

This revision now requires review to proceed.Feb 6 2017, 4:28 PM
matthew edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2017, 4:36 PM
This revision was automatically updated to reflect the committed changes.