Rework the Ti GPIO code to allow for the OMAP4 and AM335X attachments to both be present.
ClosedPublic
Actions

Authored by andrew on Oct 14 2014, 12:13 AM.

Details

Reviewers

rpaulo
loos

Group Reviewers

ARM

Commits

rS273262: Rework the Ti GPIO code to allow for both the OMAP4 and AM335X attachments

Test Plan

Boots to mountroot on Pandaoard, someone need to test on Beaglebone as I don't have one

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

andrew updated this revision to Diff 1978.Oct 14 2014, 12:13 AM

andrew retitled this revision from to Rework the Ti GPIO code to allow for the OMAP4 and AM335X attachments to both be present..

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: ARM.

andrew added inline comments.Oct 14 2014, 12:14 AM

sys/arm/ti/ti_gpio.c
644 ↗	(On Diff #1978)	This should be removed completely.

loos requested changes to this revision.Oct 14 2014, 12:53 AM

loos added a reviewer: loos.

loos added a subscriber: loos.

loos added inline comments.

sys/arm/ti/am335x/am335x_gpio.c
56 ↗	(On Diff #1978)	am335x_scm_padconf.h is missing in this patch.
61 ↗	(On Diff #1978)	"ti,am335x-gpio" maybe ?
149 ↗	(On Diff #1978)	This should be am335x_gpio_devclass (also applies to the code below).
sys/arm/ti/ti_gpio.c
886 ↗	(On Diff #1978)	This one should go too.

This revision now requires changes to proceed.Oct 14 2014, 12:53 AM

andrew added inline comments.Oct 14 2014, 9:07 AM

sys/arm/ti/am335x/am335x_gpio.c
61 ↗	(On Diff #1978)	Linux used "ti,omap4-gpio" so I'd like to support it in a small attempt on supporting their dtb files. I can add "ti,am335x-gpio" to the list.

Fixes issues raised

I have tested this on a beaglebone white, and using gpioctl I can set a pin to input and see changes on it, and set it to output and see it change when I use gpioctl to toggle it.

rpaulo accepted this revision.Oct 16 2014, 5:33 AM

rpaulo added a reviewer: rpaulo.

rpaulo added a subscriber: rpaulo.

rpaulo added inline comments.

sys/arm/ti/omap4/omap4_gpio.c
82 ↗	(On Diff #1982)	Interestingly, this doesn't handle the OUTPUT_PULLUP case and neither does the function below. I suppose that's not supported in OMAP4?

andrew added inline comments.Oct 16 2014, 11:50 AM

sys/arm/ti/omap4/omap4_gpio.c
82 ↗	(On Diff #1982)	Having a pullup on the output only makes sense if it's an open drain. If the line is driven high or low it will just increase the power draw.