loader: libefi/env.c warnings in arm build
ClosedPublic
Actions

Authored by tsoome on Feb 3 2017, 10:18 AM.

Details

Reviewers

allanjude
imp

Commits

rS313166: loader: libefi/env.c warnings in arm build

Summary

The arm build has revealed some of the warnings, the fix for CHAR16
warning is to switch the warning off for env.c (same as for efinet.c).

For error code we need to use macro.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome updated this revision to Diff 24677.Feb 3 2017, 10:18 AM

tsoome retitled this revision from to loader: libefi/env.c warnings in arm build.

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: allanjude, imp.

make buildworld TARGET_ARCH=armv6 is clean.

imp accepted this revision.Feb 3 2017, 4:21 PM

imp edited edge metadata.

imp added inline comments.

sys/boot/efi/libefi/Makefile
29 ↗	(On Diff #24677)	I recall having to have this before for a different file. Now that you've moved the code, maybe that can be removed?

This revision is now accepted and ready to land.Feb 3 2017, 4:21 PM

tsoome added inline comments.Feb 3 2017, 4:31 PM

sys/boot/efi/libefi/Makefile
29 ↗	(On Diff #24677)	The problem is that arm is is not setting wchar to 2 bytes, so anywhere we use printf format %S, this suppressor is needed, as the actual data is 2 bytes, not 4. and efi/loader/main.c is using %S.

Closed by commit rS313166: loader: libefi/env.c warnings in arm build (authored by tsoome). · Explain WhyFeb 3 2017, 4:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

Makefile

1 line

env.c

6 lines

Diff 24689

View Options

head/sys/boot/efi/libefi/Makefile