Page MenuHomeFreeBSD

net80211: cleanup ic_flags / iv_flags
ClosedPublic

Authored by avos on Jan 28 2017, 8:22 PM.

Details

Summary

Flags

  • IEEE80211_F_ASCAN
  • IEEE80211_F_SIBSS
  • IEEE80211_F_IBSSON

are not used since rS170530 (were used in old WI compatibility ioctls) / rS178354 (were removed from other places).

Not touched in this revision:

  • IEEE80211_F_COMP flag with unknown purpose;
  • IEEE80211_F_TXPOW_FIXED (never utilized); was initially added with IEEE80211_F_TXPOW_AUTO / IEEE80211_F_TXPOW_OFF flags, which were accidentally removed in rS138568. Looks like they are should be just restored, so driver can choose between EEPROM / manually chosen Tx power settings (if I understand the description correctly).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avos retitled this revision from to net80211: cleanup ic_flags / iv_flags.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
adrian edited edge metadata.

Do eeeet!

Thanks!

This revision is now accepted and ready to land.Jan 29 2017, 5:40 AM

Hmm, so what to do with IEEE80211_F_COMP / IEEE80211_F_TXPOW_FIXED (AUTO/OFF) ?

In D9369#193977, @s3erios_gmail.com wrote:

Hmm, so what to do with IEEE80211_F_COMP / IEEE80211_F_TXPOW_FIXED (AUTO/OFF) ?

I think we can remove the txpow flags; I'd rather we use the txpower config methods we have now.

F_COMP - leave that there for now; i may eventually add compression support for AR5212 chips.

This revision was automatically updated to reflect the committed changes.