Page MenuHomeFreeBSD

Eliminate misleading comments and dead code in lacp_port_create()
ClosedPublic

Authored by rpokala on Jan 23 2017, 8:19 AM.

Details

Summary

Variables "fast" and "active" are both constant in lacp_port_create(), but
comments mispleadingly suggest that "fast" can be changed via ioctl. The
constant values control the value of "lp->lp_state", so it too is constant,
and the code for assigning different value to it is essentially dead.

Remove both "fast" and "active", and set "lp->lp_state" unconditionally;
that gets rid of the dead code and misleading comments.

CID: 1305692
CID: 1305734

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rpokala retitled this revision from to Eliminate misleading comments and dead code in lacp_port_create().Jan 23 2017, 8:19 AM
rpokala updated this object.
rpokala edited the test plan for this revision. (Show Details)
rpokala added a reviewer: hiren.
rpokala added a subscriber: asomers.
rpokala updated this revision to Diff 24338.
hiren edited reviewers, added: asomers; removed: hiren.Jan 23 2017, 2:15 PM
hiren edited subscribers, added: hiren; removed: asomers.
asomers edited edge metadata.Jan 23 2017, 3:36 PM
asomers accepted this revision.
This revision is now accepted and ready to land.Jan 23 2017, 3:36 PM

Thanks. I'm tinderboxing right now, will submit when that's done.

This revision was automatically updated to reflect the committed changes.