Varnish 4 finally compiles properly on FreeBSD
move the old port to www/varnish3
still need to write an UPDATING entry
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
www/varnish/pkg-plist | ||
---|---|---|
9 | sample config files? use the @sample keyword before the sample file. |
www/varnish/Makefile | ||
---|---|---|
15 | since there is only one varnish in ports (correct?) this conflict line isn't needed pkg , will not allow the port to be installed twice. |
www/varnish/Makefile | ||
---|---|---|
15 | We'll still be offering Varnish 3.x as www/varnish3 because the config syntax is different I can remove varnish 2.x now that it is EOL, I didn't think to do so because we manually patch our ports tree as we still have some servers running Varnish 2.x | |
22–23 | I'll do a test build with that change |
Hmm seems a edit comment from me got lost, so lets repeat:
I think we can remove the autotools stuff, It seems to me that it was needed for the configure.ac patch, which was removed. So plain GNU_CONFIGURE=yes instead of USE_AUTOTOOLS will do.
www/varnish/Makefile | ||
---|---|---|
29 | Adding pathfix to USES to fix pkgconfig location instead of the post-patch. |
Comments shouldn't have leading articles, so remove The from the comment. Portlint would warn about this. Other than that, this looks fine to me.