Page MenuHomeFreeBSD
Differential D921

Integrate tests/usr.sbin/useradd from NetBSD into atf/kyua at usr.sbin/pw/tests
ClosedPublic
Actions

Authored by ngie on Oct 9 2014, 1:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 10, 8:35 PM
Unknown Object (File)
Thu, Jul 9, 9:16 PM
Unknown Object (File)
Mon, Jul 6, 6:17 PM
Unknown Object (File)
Mon, Jun 29, 7:25 PM
Unknown Object (File)
Jun 6 2026, 8:23 PM
Unknown Object (File)
Apr 26 2026, 10:02 AM
Unknown Object (File)
Apr 24 2026, 2:07 AM
Unknown Object (File)
Apr 21 2026, 1:59 AM
View All 92 Files
Subscribers
jmmv

Details

Reviewers
brd
ngie
Summary

Integrate tests/usr.sbin/useradd from NetBSD into atf/kyua at usr.sbin/pw/tests

In collaboration with: sjg
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ngie updated this revision to Diff 1926.Oct 9 2014, 1:16 AM
ngie retitled this revision from to Integrate tests/usr.sbin/useradd from NetBSD into atf/kyua at usr.sbin/pw/tests.
ngie updated this object.
ngie added a reviewer: brd.
ngie added a subscriber: jmmv.
brd edited edge metadata.Oct 9 2014, 3:58 PM

FreeBSD does support `pw useradd foo', so the sed stuff is not needed.

Please add the files you are going to import that include the tests from NetBSD.

brd added a comment.Oct 27 2014, 11:33 PM

ping

ngie added a comment.Oct 28 2014, 2:43 AM
In D921#4, @brd wrote:

FreeBSD does support `pw useradd foo', so the sed stuff is not needed.

It is because the useradd command doesn't exist on FreeBSD:

$ command -p useradd                                                                                                                                                        
-bash: useradd: command not found
$ uname -a
FreeBSD fuji-stable-10.local 10.1-PRERELEASE FreeBSD 10.1-PRERELEASE #1 f2b9523(stable/10): Sat Oct 18 15:06:02 PDT 2014     ngie@fuji-stable-10.local:/usr/obj/usr/src/sys/FUJI  amd64

Please add the files you are going to import that include the tests from NetBSD.

Sure! It's already committed to svn: https://svnweb.freebsd.org/base/head/contrib/netbsd-tests/usr.sbin/useradd/t_useradd.sh?revision=272458&view=markup

brd added a comment.Oct 28 2014, 2:55 AM

Oh, I misunderstood.

Looks good.

ngie accepted this revision.Nov 8 2014, 7:09 PM
ngie added a reviewer: ngie.

Committed in r274011 -- thanks!

This revision is now accepted and ready to land.Nov 8 2014, 7:09 PM
ngie closed this revision.Nov 8 2014, 7:09 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pw/
tests/
14 lines

Diff 1926

View Options

usr.sbin/pw/tests/Makefile

Loading...