Page MenuHomeFreeBSD
Differential D9205

Change ownership of rundeck/server/lib et al.
ClosedPublic
Actions

Authored by ler on Jan 17 2017, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 9:32 AM
Unknown Object (File)
Nov 26 2024, 4:06 PM
Unknown Object (File)
Nov 21 2024, 11:58 AM
Unknown Object (File)
Nov 11 2024, 10:53 AM
Unknown Object (File)
Nov 1 2024, 2:51 PM
Unknown Object (File)
Oct 29 2024, 4:29 PM
Unknown Object (File)
Oct 25 2024, 8:12 AM
Unknown Object (File)
Oct 19 2024, 9:16 PM
View All Files
Subscribers
mat

Details

Reviewers
adamw
rene
Commits
rP431715: Change ownership of rundeck/server/lib et al.
Summary

Change ownership of rundeck/server/lib et al.
Address poudriere issues
bump PORTREVISION

PR: 202732
Submitted by: Mark C Ballew (ballew sublinear net)
Approved by: (adamw|rene) (mentor)
MFH: 2017Q1 (blanket)

Test Plan

poudriere (ok)
http://home.lerctr.org:8888/data/live-ler-checkout/2017-01-16_18h42m54s/logs/rundeck-2.3.2_1.log

portlint (ok)
borg.lerctr.org ~/FreeBSD/ports/sysutils/rundeck $ portlint -C
WARN: Makefile: possible use of absolute pathname "/var/log/rundeck.log".
0 fatal errors and 1 warning found.
borg.lerctr.org ~/FreeBSD/ports/sysutils/rundeck $

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ler updated this revision to Diff 24091.Jan 17 2017, 12:50 AM
ler retitled this revision from to Change ownership of rundeck/server/lib et al..
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.
Herald added a subscriber: mat. · View Herald TranscriptJan 17 2017, 12:50 AM
adamw edited edge metadata.Jan 17 2017, 12:51 AM

You should follow portlint's advice.

ler updated this object.Jan 17 2017, 12:52 AM
ler edited edge metadata.
adamw added inline comments.Jan 17 2017, 12:52 AM
sysutils/rundeck/pkg-plist
2 ↗(On Diff #24091)

@dir goes at the end of the plist.

adamw added inline comments.Jan 17 2017, 12:54 AM
sysutils/rundeck/Makefile
42 ↗(On Diff #24091)

${MKDIR} commands should be muted.

43 ↗(On Diff #24091)

Now that you have @dir in the plist, you don't need to create this file.

sysutils/rundeck/pkg-plist
3 ↗(On Diff #24091)

You have @dir. You don't need to trick the system with a .keep file.

ler updated this revision to Diff 24092.Jan 17 2017, 12:55 AM

Address portlint DATADIR

ler updated this revision to Diff 24093.Jan 17 2017, 12:56 AM

Uh, use the right diff.

ler edited the test plan for this revision. (Show Details)Jan 17 2017, 12:57 AM
ler updated this revision to Diff 24094.Jan 17 2017, 12:58 AM

update plist per Adam

ler updated this revision to Diff 24095.Jan 17 2017, 1:05 AM

Address Adam's comment re: .keep

ler marked 4 inline comments as done.Jan 17 2017, 1:06 AM
adamw accepted this revision.Jan 17 2017, 1:13 AM
adamw edited edge metadata.
adamw added inline comments.
sysutils/rundeck/pkg-plist
3 ↗(On Diff #24095)

These @dir entries should be in reverse-alphabetical order. Just switch them before committing.

This revision is now accepted and ready to land.Jan 17 2017, 1:13 AM
Closed by commit rP431715: Change ownership of rundeck/server/lib et al. (authored by ler). · Explain WhyJan 17 2017, 1:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
rundeck/
8 lines
3 lines

Diff 24096

View Options

head/sysutils/rundeck/Makefile

Loading...
View Options

head/sysutils/rundeck/pkg-plist

Loading...