Page MenuHomeFreeBSD

Change ownership of rundeck/server/lib et al.
ClosedPublic

Authored by ler on Jan 17 2017, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 9:44 AM
Unknown Object (File)
Feb 9 2024, 9:44 AM
Unknown Object (File)
Feb 9 2024, 9:43 AM
Unknown Object (File)
Feb 9 2024, 9:43 AM
Unknown Object (File)
Feb 9 2024, 9:43 AM
Unknown Object (File)
Feb 9 2024, 9:43 AM
Unknown Object (File)
Feb 9 2024, 9:43 AM
Unknown Object (File)
Feb 8 2024, 10:02 PM
Subscribers

Details

Summary

Change ownership of rundeck/server/lib et al.
Address poudriere issues
bump PORTREVISION

PR: 202732
Submitted by: Mark C Ballew (ballew sublinear net)
Approved by: (adamw|rene) (mentor)
MFH: 2017Q1 (blanket)

Test Plan

poudriere (ok)
http://home.lerctr.org:8888/data/live-ler-checkout/2017-01-16_18h42m54s/logs/rundeck-2.3.2_1.log

portlint (ok)
borg.lerctr.org ~/FreeBSD/ports/sysutils/rundeck $ portlint -C
WARN: Makefile: possible use of absolute pathname "/var/log/rundeck.log".
0 fatal errors and 1 warning found.
borg.lerctr.org ~/FreeBSD/ports/sysutils/rundeck $

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ler retitled this revision from to Change ownership of rundeck/server/lib et al..
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.

You should follow portlint's advice.

ler edited edge metadata.
sysutils/rundeck/pkg-plist
2 ↗(On Diff #24091)

@dir goes at the end of the plist.

sysutils/rundeck/Makefile
42 ↗(On Diff #24091)

${MKDIR} commands should be muted.

43 ↗(On Diff #24091)

Now that you have @dir in the plist, you don't need to create this file.

sysutils/rundeck/pkg-plist
3 ↗(On Diff #24091)

You have @dir. You don't need to trick the system with a .keep file.

Address portlint DATADIR

Address Adam's comment re: .keep

ler marked 4 inline comments as done.Jan 17 2017, 1:06 AM
adamw edited edge metadata.
adamw added inline comments.
sysutils/rundeck/pkg-plist
3 ↗(On Diff #24095)

These @dir entries should be in reverse-alphabetical order. Just switch them before committing.

This revision is now accepted and ready to land.Jan 17 2017, 1:13 AM
This revision was automatically updated to reflect the committed changes.