Page MenuHomeFreeBSD
Differential D9190

Update sysutils/mcelog.
ClosedPublic
Actions

Authored by ler on Jan 15 2017, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 1:51 PM
Unknown Object (File)
Thu, Dec 5, 1:51 PM
Unknown Object (File)
Thu, Dec 5, 1:51 PM
Unknown Object (File)
Wed, Dec 4, 4:21 PM
Unknown Object (File)
Sun, Dec 1, 7:50 AM
Unknown Object (File)
Nov 21 2024, 3:53 PM
Unknown Object (File)
Nov 18 2024, 10:59 AM
Unknown Object (File)
Oct 31 2024, 10:52 AM
View All 66 Files
Subscribers
mat

Details

Reviewers
adamw
rene
Commits
rP431601: Update sysutils/mcelog to version 147.
Summary

Update sysutils/mcelog to version 147.

  • Updated to 147
    • mcelog: is_cpu_supported() error message must be printed Eprintf

PR: 216116
Submitted by: Ultima <Ultima1252 gmail com> (maintainer)
Approved by: (adamw|rene) (mentor)

Test Plan

poudriere (ok)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ler updated this revision to Diff 24035.Jan 15 2017, 4:37 PM
ler retitled this revision from to Update sysutils/mcelog..
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.
Herald added a subscriber: mat. · View Herald TranscriptJan 15 2017, 4:37 PM
ler added a comment.Jan 15 2017, 4:40 PM

Poudriere log:
http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-15_10h38m52s/logs/mcelog-147.log

rene edited edge metadata.Jan 15 2017, 9:05 PM

The patch and log look fine, but the commit message looks a bit verbose?

How about

Update sysutils/mcelog to version 147.

  • Updated to 147
    • mcelog: is_cpu_supported() error message must be printed Eprintf

?

ler updated this object.Jan 15 2017, 9:11 PM
ler edited the test plan for this revision. (Show Details)
ler edited edge metadata.
ler updated this object.Jan 15 2017, 9:13 PM
ler updated this object.

valid. comment, @rene done.

rene added a comment.EditedJan 15 2017, 9:27 PM

Almost fine, but your keyboard shifted?

"ewnw" instead of "rene" in the "Approved by" line

ler updated this object.Jan 15 2017, 9:29 PM

I hate off-by-1 keyboard errors, especially on mentor ID's :)

Sorry 'bout that.

rene accepted this revision.Jan 15 2017, 9:46 PM
rene edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2017, 9:46 PM
Closed by commit rP431601: Update sysutils/mcelog to version 147. (authored by ler). · Explain WhyJan 15 2017, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
mcelog/
2 lines
6 lines

Diff 24044

View Options

head/sysutils/mcelog/Makefile

Loading...
View Options

head/sysutils/mcelog/distinfo

Loading...