Differential D9187

Ensure arswitch is always locked when calling arswitch_modifyreg()
ClosedPublic
Actions

Authored by kp on Jan 14 2017, 11:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 9, 5:31 PM

	Unknown Object (File)
	Sun, May 3, 1:01 AM

	Unknown Object (File)
	Thu, Apr 30, 1:36 PM

	Unknown Object (File)
	Sat, Apr 25, 9:06 AM

	Unknown Object (File)
	Thu, Apr 23, 12:38 AM

	Unknown Object (File)
	Wed, Apr 22, 5:55 PM

	Unknown Object (File)
	Apr 9 2026, 7:34 PM

	Unknown Object (File)
	Apr 9 2026, 1:45 PM

Subscribers

Details

Reviewers

kan
adrian

Commits

rS312224: arswitch: Ensure the lock is always held when calling arswitch_modifyreg()

Summary

While upgrading my TPLink 3600 to a less ancient FreeBSD version I encountered a panic (panic: mutex arswitch not owned at .../sys/dev/etherswitch/arswitch/arswitch_reg.c:236).
This happened because arswitch_modifyreg() can be called without having the arswitch lock held.

Test Plan

Boot TPLink 3600.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp updated this revision to Diff 24012.Jan 14 2017, 11:44 PM

kp retitled this revision from to Ensure arswitch is always locked when calling arswitch_modifyreg().

kp updated this object.

kp edited the test plan for this revision. (Show Details)

kp added a reviewer: adrian.

kp set the repository for this revision to rS FreeBSD src repository - subversion.

kp added a subscriber: adrian.

Herald added a subscriber: imp. · View Herald TranscriptJan 14 2017, 11:44 PM

yup! good catch!

This revision is now accepted and ready to land.Jan 14 2017, 11:46 PM

Yup

Closed by commit rS312224: arswitch: Ensure the lock is always held when calling arswitch_modifyreg() (authored by kp). · Explain WhyJan 15 2017, 10:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

etherswitch/

arswitch/

8 lines

arswitch_7240.c

4 lines

arswitch_8316.c

3 lines

arswitch_8327.c

3 lines

arswitch_9340.c

4 lines

Diff 24031

head/sys/dev/etherswitch/arswitch/arswitch.c

Loading...

head/sys/dev/etherswitch/arswitch/arswitch_7240.c

Loading...

head/sys/dev/etherswitch/arswitch/arswitch_8316.c

Loading...

head/sys/dev/etherswitch/arswitch/arswitch_8327.c

Loading...

head/sys/dev/etherswitch/arswitch/arswitch_9340.c

Loading...