Update lang/sbcl to 1.3.13
Give MAINTAINERship to submitter, modernize port.
PR: 215866
Submitted by: Pavel Volkov (pavelivolkov gmail com)
Approved by: (adamw|rene) (mentor)
Details
Details
- Reviewers
adamw rene - Commits
- rP431505: Update lang/sbcl to 1.3.13
poudriere (ok)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lang/sbcl/Makefile | ||
|---|---|---|
| 59 ↗ | (On Diff #24008) | What is the circumstance under which PREFIX would be defined, but not LOCALBASE? I don't like this block... previously-installed stuff should be in LOCALBASE, not PREFIX. |
| 73 ↗ | (On Diff #24008) | This block doesn't make any sense either. It changes depending upon what's installed before make config is run. In poudriere, NONE of them will be installed. Pick one, and make it the default. This block is so clever that it won't work. |
| 132 ↗ | (On Diff #24008) | Not right, because it discards the environment. Alternatives: DOCS_ALL_TARGET= all info html post-build-DOCS-on:
${DO_MAKE_BUILD} -C ${WRKSRC}/doc/manual info html |
| 147 ↗ | (On Diff #24008) | What's with all the quoted paths? |
| 150 ↗ | (On Diff #24008) | No. OPTIONS handles this already. |
| 152 ↗ | (On Diff #24008) | How many different ways is this planning on being called? |
Comment Actions
Addressed all comments, except the test comment, I'm not a lisp guy
so I don't know enough about how their test suite is done.
poudriere log:
http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-14_17h56m18s/logs/sbcl-1.3.13,1.log
Comment Actions
Address Adam's comments.
Poudriere Run:
http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-14_18h18m19s/logs/sbcl-1.3.13,1.log
Comment Actions
Kill tabs after OPTIONS_DEFINE, OPTIONS_DEFAULT, Upper-case initial characters of
RENAME_DESC, SAFEPOINT_DESC.
| lang/sbcl/Makefile | ||
|---|---|---|
| 89 ↗ | (On Diff #24019) | This should be up at line 68. But really, it should be this: RENAME_PLIST_SUB= RENAME_DLM="_" RENAME_PLIST_SUB_OFF= RENAME_DLM="." |
Comment Actions
This port needs more work.
The proper bootstrap procedure was removed (using an existing bootstrap compiler listed in distinfo).
The effect is that the previous version built on DragonFly, but now it doesn't. CCl is a FreeBSD-only port.
What needs to happen is the SBCL option needs to change to loading a bootstrap compiler, not using "sbcl" from the installed host, which is really unacceptable in the age of poudriere and synth. We don't encourage "live" building anymore.
Comment Actions
FYI, that wasn't a rhetorical comment.
This port needs to have the sbcl bootstrap returned (and be the default build approach IMO).
The maintainer should be notified.
I might fix it myself; somebody has it.
I think DF should have been contacted during the review because there was a clear special handling for DF there, so a complete revamp of the build should have raised flags.