Page MenuHomeFreeBSD

contrib/dtc/checks.c: quiesce clang warning
ClosedPublic

Authored by sbruno on Oct 7 2014, 7:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 12:53 AM
Unknown Object (File)
Thu, Nov 14, 12:30 AM
Unknown Object (File)
Wed, Nov 13, 8:39 PM
Unknown Object (File)
Mon, Nov 11, 11:40 AM
Unknown Object (File)
Fri, Nov 1, 1:51 AM
Unknown Object (File)
Sep 21 2024, 2:22 AM
Unknown Object (File)
Sep 18 2024, 2:56 AM
Unknown Object (File)
Sep 17 2024, 8:32 PM
Subscribers
None

Details

Summary

Silence clang warning about extraneous parenthsis

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbruno retitled this revision from to contrib/dtc/checks.c: quiesce clang warning.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added a reviewer: imp.

This is OK, but can you check to see if a newer version of upstream dtc has this fix already? I'd rather import it that way than like this since it has the potential for complicating future imports.

In D913#3, @imp wrote:

This is OK, but can you check to see if a newer version of upstream dtc has this fix already? I'd rather import it that way than like this since it has the potential for complicating future imports.

I checked the URLs in the source and can't seem to find this software online anymore. Did it move to gnu.org or something?

In D913#4, @sbruno wrote:
In D913#3, @imp wrote:

This is OK, but can you check to see if a newer version of upstream dtc has this fix already? I'd rather import it that way than like this since it has the potential for complicating future imports.

I checked the URLs in the source and can't seem to find this software online anymore. Did it move to gnu.org or something?

oh is this it?
http://www.devicetree.org/Device_Tree_Compiler

Verified that upstream code has the same issue. Still trying to figure out where the mailing list for this project actually is.

From git://xenbits.xen.org/people/ianc/device-tree-rebasing

is where I've been grabbing from...

Oh, wait, that's for the .dts files.

Hrm, I have no real clue where this code comes from ...

https://git.kernel.org/cgit/utils/dtc/dtc.git/tree/checks.c#n628

Confirmed that this matches upstream. I don't know of anyone that is getting ready to update dtc though, should I just commit this?

imp edited edge metadata.

These are fine. They look correct and have been verified upstream. Committing will cause no issues for next update.

This revision is now accepted and ready to land.Jun 5 2015, 4:40 PM
This revision was automatically updated to reflect the committed changes.