Page MenuHomeFreeBSD

PR 213560 upgrade www/obhttpd to 6.0
ClosedPublic

Authored by ler on Jan 11 2017, 4:15 AM.

Details

Summary

upgrade www/obhttpd to 6.0.20161006
modernized the Uses / USE_OPENSSL usage

PR: 213560
Submitted by: koue@chaosophia.net (Maintainer)
Approved by: adamw (mentor)

Test Plan

poudriere testport (ok)
portlint -Ac (ok)

I'll also mention "committed with minor changes" in the PR close message

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ler retitled this revision from to PR 213560 upgrade www/obhttpd to 6.0.
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.
ler set the repository for this revision to rP FreeBSD ports repository.
Makefile
12 ↗(On Diff #23866)

That doesn't look right.

Try just
WRKSRC_SUBDIR= src

41 ↗(On Diff #23866)

What about just

${INSTALL_DATA} ${WRKSRC}/etc/examples...

You need to add the pkg-plist here as well.

Makefile
12 ↗(On Diff #23866)

> Patching for obhttpd-6.0.20161006

/usr/bin/sed -i.bak -e 's|httpd$|obhttpd|g' -e 's|httpd.conf.5|obhttpd.conf.5|g' -e 's|httpd.8|obhttpd.8|g' src/usr.sbin/httpd/Makefile
sed: src/usr.sbin/httpd/Makefile: No such file or directory

  • Error code 1
ler edited edge metadata.

added pkg-plist. trying wrksrc = src fails

Makefile
12 ↗(On Diff #23866)

I think you set WRKSRC, not WRKSRC_SUBDIR.

pkg-plist
1 ↗(On Diff #23867)

This should be a @sample.

ler edited the test plan for this revision. (Show Details)

address adamw's comments

@sample added

ler marked 4 inline comments as done.Jan 11 2017, 4:45 AM
Makefile
47 ↗(On Diff #23869)

One last thing. This message looks really sloppy when printed.

s/need/needs/, s/set/Set/

ler marked 2 inline comments as done.Jan 11 2017, 4:52 AM

address comments

adamw edited edge metadata.

Phew! Okay good work.

In your PR close message, ask Nikola to take a look at net/openntpd and security/acme-client and see whether that setup would work for this port too.

This revision is now accepted and ready to land.Jan 11 2017, 4:54 AM
This revision was automatically updated to reflect the committed changes.