Add SDHCI ACPI driver
ClosedPublic
Actions

Authored by gonzo on Jan 10 2017, 3:09 AM.

Details

Reviewers

imp
• ian

Commits

rS311911: [sdhci] Add ACPI platform support for SDHCI driver

Summary

Add ACPI platform wrapper for SDHCI devices. Some systems
(like BayTrail-based Minnowboard Turbot) have them on ACPI instead of PCI

Test Plan

Load modules on Minnowboard Turbot, and check if SD card
is recognized/works

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo updated this revision to Diff 23803.Jan 10 2017, 3:09 AM

gonzo retitled this revision from to Add SDHCI ACPI driver.

gonzo updated this object.

gonzo edited the test plan for this revision. (Show Details)

gonzo added reviewers: imp, • ian.

Looks good.

This revision is now accepted and ready to land.Jan 10 2017, 3:48 AM

Seems reasonable, but a lot of code to duplicate. Wonder if these will work with the Chromebook I have? It's having issues with the USB devices and I need to get a toe-hold in there somehow.

sys/dev/sdhci/sdhci_acpi.c
46–47 ↗	(On Diff #23803)	Are these the right paths? They look rather long...
73–74 ↗	(On Diff #23803)	why the hex IDs as text here? Seems redundant... Does the ACPI probing code really need the HID as a string?

gonzo added inline comments.Jan 10 2017, 5:31 AM

sys/dev/sdhci/sdhci_acpi.c
46–47 ↗	(On Diff #23803)	Yes, these are includes for ACPI stuff. accommon.h is not actually required, but the first one is.
73–74 ↗	(On Diff #23803)	As far as I understand ACPI HID is a string. Because it can be something like "INT33C2".