Page MenuHomeFreeBSD

www/py-django-crispy-forms: fix django dependency
ClosedPublic

Authored by xmj on Oct 7 2014, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 9, 5:17 AM
Unknown Object (File)
Wed, Jul 8, 5:07 AM
Unknown Object (File)
Wed, Jul 8, 3:57 AM
Unknown Object (File)
Tue, Jul 7, 5:14 PM
Unknown Object (File)
Tue, Jul 7, 3:30 AM
Unknown Object (File)
Sun, Jul 5, 6:00 AM
Unknown Object (File)
Sat, Jul 4, 8:07 AM
Unknown Object (File)
Sat, Jul 4, 2:35 AM
Subscribers
None

Details

Reviewers
swills
koobs
Summary
  • Fix django dependency, now that www/py-django was bumped to 1.7

    www/py-django-crispy-forms: fix django dependency
    • Fix django dependency, now that www/py-django was bumped to 1.7

      (DiffRev:...) Approved by: swills (mentor)
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xmj retitled this revision from to www/py-django-crispy-forms: fix django dependency.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: swills, koobs.

Are you sure we support this syntax:

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django<1.7:${PORTSDIR}/www/py-django16

I think it should be

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django16>=1.6:${PORTSDIR}/www/py-django16

xmj edited edge metadata.

Amend Makefile

the package name for django 1.6 is "django16" not "django", so if it needs to pull that in, it should be:

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django16>=1.6:${PORTSDIR}/www/py-django16

If 1.7 works, then it should be:

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django>=1.7:${PORTSDIR}/www/py-django

I don't know if this supports 1.7 or not.

In D909#6, @swills wrote:

the package name for django 1.6 is "django16" not "django", so if it needs to pull that in, it should be:

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django16>=1.6:${PORTSDIR}/www/py-django16

Yeah, should've seen that.

If 1.7 works, then it should be:

RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django>=1.7:${PORTSDIR}/www/py-django

I don't know if this supports 1.7 or not.

Around the time when I made that port it (explicitly) didn't support 1.7, and hasn't been updated in a while nor touched on GitHub..

swills edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Oct 7 2014, 2:39 PM

Committed revision 370345.