Paths

Table of Contentst

Differential D9074

Fix a file descriptor leak in cmp(1)
ClosedPublic
Actions

Authored by asomers on Jan 6 2017, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 2, 5:20 PM

	Unknown Object (File)
	Fri, Jan 24, 7:38 PM

	Unknown Object (File)
	Fri, Jan 24, 7:37 PM

	Unknown Object (File)
	Fri, Jan 24, 7:36 PM

	Unknown Object (File)
	Sat, Jan 18, 6:23 AM

	Unknown Object (File)
	Fri, Jan 17, 3:31 PM

	Unknown Object (File)
	Jan 8 2025, 4:47 AM

	Unknown Object (File)
	Jan 1 2025, 4:55 PM

Subscribers

Details

Reviewers

Commits

rS311572: Fix file descriptor leaks in cmp(1)

Summary

Fix a file descriptor leak in cmp(1)

Also, add a few test cases

Reported by: Coverity
CID: 271624

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 23683.Jan 6 2017, 10:41 PM

asomers retitled this revision from to Fix a file descriptor leak in cmp(1).

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: ngie.

Herald added a subscriber: imp. · View Herald TranscriptJan 6 2017, 10:41 PM

ngie added inline comments.Jan 6 2017, 11:04 PM

contrib/netbsd-tests/usr.bin/cmp/t_cmp.sh
63–98 ↗	(On Diff #23683)	Please add `# Begin FreeBSD` and `# End FreeBSD` to denote the changes we added.
93 ↗	(On Diff #23683)	`-e ignore -x` for consistency?
usr.bin/cmp/special.c
102 ↗	(On Diff #23683)	What about `fp2`?

asomers added inline comments.Jan 6 2017, 11:17 PM

contrib/netbsd-tests/usr.bin/cmp/t_cmp.sh
63–98 ↗	(On Diff #23683)	I can do that, or I can create a separate test file for our tests. Which would you prefer?
93 ↗	(On Diff #23683)	Ok.
usr.bin/cmp/special.c
102 ↗	(On Diff #23683)	Grr, I should've seen that. Still, I wish Coverity would sanely sort its output.

ngie added inline comments.Jan 6 2017, 11:24 PM

contrib/netbsd-tests/usr.bin/cmp/t_cmp.sh
63–98 ↗	(On Diff #23683)	I think this makes sense. It might be a good idea to push this back to NetBSD..

Incorporate ngie's feedback

ngie accepted this revision.Jan 7 2017, 12:37 AM

ngie edited edge metadata.

ngie added inline comments.

usr.bin/cmp/tests/Makefile
5–6 ↗	(On Diff #23686)	Please... use `+=` to ensure that the value of ${ATF_TESTS_SH} put `ATF_TESTS_SH+=` above `NETBSD_ATF_TESTS_SH` for sorting purposes.

This revision is now accepted and ready to land.Jan 7 2017, 12:37 AM

Closed by commit rS311572: Fix file descriptor leaks in cmp(1) (authored by asomers). · Explain WhyJan 7 2017, 12:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

cmp/

2 lines

tests/

1 line

67 lines

Diff 23688

head/usr.bin/cmp/special.c

Loading...

head/usr.bin/cmp/tests/Makefile

Loading...

head/usr.bin/cmp/tests/cmp_test2.sh

Loading...