Add a testcase for aio_suspend

[jhb]

This looks fine overall. I think it wouldn't be bad if we had an aio_suspend test of all the various file types, not just for vnodes.

tests/sys/aio/aio_test.c

1077 ↗

(On Diff #23612)

These are roughly in order that the functions are defined, so I think this should be moved up?

[asomers]

Substantially update review:

• add tests for polled completion notification
• test the full matrix of file descriptor types and completion notification mechanisms.
• Don't bother with mkstemp, because ATF runs every test in its own temp dir.
• Fix some typos
• Remove extraneous ATF_REQUIRE_KERNEL_MODULE calls

[asomers]

Does this look ok to you, @jhb ?

[jhb]

tests/sys/aio/aio_test.c

77 ↗

(On Diff #23753)

I would put a blank line here (I know it was missing in the original code)

221 ↗

(On Diff #23753)

You might want to ATF_REQUIRE that the returned aiocb from aio_waitcomplete() matches the passed in aiocb.

384 ↗

(On Diff #23753)

Only caveat about removing mkstemp() is that I often run tests standalone. In particular, kyua has very poor integration with debuggers, so the only way to single step a test to debug a failure is to run it outside of kyua. :-/

[asomers]

tests/sys/aio/aio_test.c

221 ↗

(On Diff #23753)

good idea.

384 ↗

(On Diff #23753)

For those cases, I usually cd to /tmp, then invoke the test by its absolute pathname. That way, temporary files get created in /tmp.