Page MenuHomeFreeBSD

www/seahub: Updated to 6.0.5
ClosedPublic

Authored by lifanov on Dec 29 2016, 7:09 PM.

Details

Summary
* Updated to 6.0.5

 - Merge pull request #1403 from haiwen/count-users
 - update post args when generate encrypted share link
 - [repo-folder-perm-admin] fix
 - update encoding check when edit file
 - [my libs] don't show operations for broken library
 - [trash] added 'go back'
 - [file revisions] added 'back'
 - update admin del damaged repo
 - add space usage/quota info when export user to excel
 - [i18n] Update fr locale

 PR: 215638
 Submitted by: Ultima1252@gmail.com (maintainer)
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential revision: https://reviews.freebsd.org/DXXXX
Test Plan

poudriere testport - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lifanov updated this revision to Diff 23415.Dec 29 2016, 7:09 PM
lifanov retitled this revision from to www/seahub: Updated to 6.0.5.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added a reviewer: matthew.
lifanov added a subscriber: koobs.
lifanov updated this revision to Diff 23418.Dec 29 2016, 8:09 PM

switch to path under head/

mat added inline comments.Dec 29 2016, 10:42 PM
www/seahub/Makefile
16 ↗(On Diff #23418)

This is wrong, it must be ${LOCALBASE}.

  • PREFIX is where the port installs itself, therefore, it is supposed to be empty before installing.
  • LOCALBASE is where the dependencies are installed.
matthew edited edge metadata.Dec 30 2016, 8:42 AM

Apart from fixing the problem Mat highlighted, this looks good.

lifanov updated this revision to Diff 23450.Dec 30 2016, 12:57 PM
lifanov edited edge metadata.

address mat's feedback

Yep, makes sense

matthew accepted this revision.Dec 30 2016, 2:38 PM
matthew edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 30 2016, 2:38 PM
This revision was automatically updated to reflect the committed changes.