Page MenuHomeFreeBSD

security/hashcat: small fixes
ClosedPublic

Authored by lifanov on Dec 29 2016, 6:24 PM.

Details

Summary
o fix shebang on sample bash completion installer
o respect ${CC}

Reported by: AMDmi3
Reviewed by: matthew
Approved by: matthew (mentor)
Differential revision: https://reviews.freebsd.org/DXXXX
Test Plan

poudriere testport - OK
runtime - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lifanov updated this revision to Diff 23410.Dec 29 2016, 6:24 PM
lifanov retitled this revision from to security/hashcat: small fixes.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added a reviewer: matthew.
lifanov added a subscriber: koobs.
matthew edited edge metadata.Dec 29 2016, 7:13 PM

What's with all the paths in your diffs suddenly having head/ prepended to them?

I started running arc at the root of the repo. Is this bad?

I can update these to under head if you like.

It would be slightly easier for me if you run from $PORTSDIR -- most people tend to check out svn+ssh://matthew@repo.freebsd.org/ports/head as .../ports. But it's not a big deal.

lifanov updated this revision to Diff 23416.Dec 29 2016, 8:08 PM
lifanov edited edge metadata.

switch to path under head/

mat added inline comments.Dec 29 2016, 10:40 PM
security/hashcat/Makefile
17 ↗(On Diff #23416)

This should be gsed:textproc/gsed

security/hashcat/files/patch-src_Makefile
7 ↗(On Diff #23416)

Instead of removing the CC lines here, you could set MAKE_ARGS= CC=${CC} in the port's Makefile

Looks good once you've addressed Mat's points.

lifanov updated this revision to Diff 23451.Dec 30 2016, 1:01 PM

address mat's feedback

o switch to MAKE_ARGS - good point, this is way better!
o use gsed in dependency line
o pet portlint for section order

lifanov updated this revision to Diff 23452.Dec 30 2016, 1:03 PM

whoops, regen patch 1/2

lifanov updated this revision to Diff 23453.Dec 30 2016, 1:03 PM

whoops, regen patch 2/2

lifanov updated this revision to Diff 23456.Dec 30 2016, 2:15 PM

replace local patch with the one that got upstreamed

This allows next version to be patch-free.
This passes poudriere testport still and runtime works.

lifanov updated this revision to Diff 23457.Dec 30 2016, 2:16 PM

exclude seahub again

matthew accepted this revision.Dec 30 2016, 3:00 PM
matthew edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 30 2016, 3:00 PM
This revision was automatically updated to reflect the committed changes.