security/hashcat: small fixes

[lifanov]

Summary

o fix shebang on sample bash completion installer
o respect ${CC}

Reported by: AMDmi3
Reviewed by: matthew
Approved by: matthew (mentor)
Differential revision: https://reviews.freebsd.org/DXXXX

Test Plan

poudriere testport - OK
runtime - OK

[matthew]

What's with all the paths in your diffs suddenly having head/ prepended to them?

[lifanov]

I started running arc at the root of the repo. Is this bad?

[lifanov]

I can update these to under head if you like.

[matthew]

It would be slightly easier for me if you run from $PORTSDIR -- most people tend to check out svn+ssh://[e-mail]/ports/head as .../ports. But it's not a big deal.

[lifanov]

switch to path under head/

[mat]

security/hashcat/Makefile

17 ↗

(On Diff #23416)

This should be gsed:textproc/gsed

security/hashcat/files/patch-src_Makefile

7 ↗

(On Diff #23416)

Instead of removing the CC lines here, you could set MAKE_ARGS= CC=${CC} in the port's Makefile

[matthew]

Looks good once you've addressed Mat's points.

[lifanov]

address mat's feedback

o switch to MAKE_ARGS - good point, this is way better!
o use gsed in dependency line
o pet portlint for section order

[lifanov]

whoops, regen patch 1/2

[lifanov]

whoops, regen patch 2/2

[lifanov]

replace local patch with the one that got upstreamed

This allows next version to be patch-free.
This passes poudriere testport still and runtime works.

[lifanov]

exclude seahub again

[matthew]

LGTM