Page MenuHomeFreeBSD
Differential D8770

lifanov: add an author entity
ClosedPublic
Actions

Authored by lifanov on Dec 13 2016, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 3:53 PM
Unknown Object (File)
Sat, May 24, 2:13 PM
Unknown Object (File)
Wed, May 21, 5:44 PM
Unknown Object (File)
Sat, May 17, 5:41 PM
Unknown Object (File)
Wed, May 14, 2:42 PM
Unknown Object (File)
Thu, May 8, 4:53 AM
Unknown Object (File)
Wed, May 7, 1:36 AM
Unknown Object (File)
Apr 25 2025, 2:55 PM
View All 41 Files
Subscribers
koobs

Details

Reviewers
matthew
Commits
rD49726: add an author entity for myself
Summary

Per New Committer guide, add an author entity to authors.ent

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lifanov updated this revision to Diff 22867.Dec 13 2016, 2:49 PM
lifanov retitled this revision from to lifanov: add an author entity.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added a reviewer: matthew.
lifanov added a subscriber: koobs.
matthew accepted this revision.Dec 13 2016, 3:01 PM
matthew edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 3:01 PM
lifanov added a comment.Dec 13 2016, 3:08 PM

Hi matthew, I noticed that several past committers did steps 1-4 all at once. Is this preferred?

matthew added a comment.Dec 13 2016, 3:17 PM

Up to you. I don't think there's any pressing reason to commit everything in one go. Actually, given you've created these reviews -- you would usually close the review by committing the change and adding the review URL (ie. https://reviews.freebsd.org/D8770) in the appropriate place in the commit template. Not sure if that works for closing several reviews at once, so I'd advise doing each of these separately.

Closed by commit rD49726: add an author entity for myself (authored by lifanov). · Explain WhyDec 13 2016, 3:48 PM
This revision was automatically updated to reflect the committed changes.
lifanov added a comment.Dec 13 2016, 3:50 PM

OK, great! Before I do others, can you look at this commit please and just do a sanity check (props correct, message formatted correctly, etc.) please?

matthew added a comment.Dec 13 2016, 3:58 PM

That looks fine to me.

I forgot to mention that you should always use svn to make these commits rather than trying to use 'arc land ...' -- so long as you reference the review in the commit message everything will work fine. 'arc land ...' tends to screw up the preferred commit message formatting.

lifanov added a comment.Dec 13 2016, 4:46 PM

Yes, I figured not to use "arc land" just in case.

Revision Contents
Changeset List

PathSize
head/
share/
xml/
3 lines

Diff 22876

View Options

head/share/xml/authors.ent

Loading...