Page MenuHomeFreeBSD

lifanov: add an author entity
ClosedPublic

Authored by lifanov on Dec 13 2016, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:55 AM
Unknown Object (File)
Sep 2 2023, 7:28 PM
Unknown Object (File)
Aug 13 2023, 12:51 PM
Unknown Object (File)
Aug 3 2023, 2:44 AM
Unknown Object (File)
Jul 23 2023, 9:09 AM
Unknown Object (File)
Jul 15 2023, 1:17 PM
Unknown Object (File)
Jun 15 2023, 7:59 AM
Unknown Object (File)
May 21 2023, 4:59 AM
Subscribers

Details

Summary

Per New Committer guide, add an author entity to authors.ent

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lifanov retitled this revision from to lifanov: add an author entity.
lifanov updated this object.
lifanov edited the test plan for this revision. (Show Details)
lifanov added a reviewer: matthew.
lifanov added a subscriber: koobs.
matthew edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 3:01 PM

Hi matthew, I noticed that several past committers did steps 1-4 all at once. Is this preferred?

Up to you. I don't think there's any pressing reason to commit everything in one go. Actually, given you've created these reviews -- you would usually close the review by committing the change and adding the review URL (ie. https://reviews.freebsd.org/D8770) in the appropriate place in the commit template. Not sure if that works for closing several reviews at once, so I'd advise doing each of these separately.

This revision was automatically updated to reflect the committed changes.

OK, great! Before I do others, can you look at this commit please and just do a sanity check (props correct, message formatted correctly, etc.) please?

That looks fine to me.

I forgot to mention that you should always use svn to make these commits rather than trying to use 'arc land ...' -- so long as you reference the review in the commit message everything will work fine. 'arc land ...' tends to screw up the preferred commit message formatting.

Yes, I figured not to use "arc land" just in case.