Per New Committer guide, add an author entity to authors.ent
Details
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Hi matthew, I noticed that several past committers did steps 1-4 all at once. Is this preferred?
Up to you. I don't think there's any pressing reason to commit everything in one go. Actually, given you've created these reviews -- you would usually close the review by committing the change and adding the review URL (ie. https://reviews.freebsd.org/D8770) in the appropriate place in the commit template. Not sure if that works for closing several reviews at once, so I'd advise doing each of these separately.
OK, great! Before I do others, can you look at this commit please and just do a sanity check (props correct, message formatted correctly, etc.) please?
That looks fine to me.
I forgot to mention that you should always use svn to make these commits rather than trying to use 'arc land ...' -- so long as you reference the review in the commit message everything will work fine. 'arc land ...' tends to screw up the preferred commit message formatting.