Page MenuHomeFreeBSD
Differential D877

Close ENTRY sections in assembly files
ClosedPublic
Actions

Authored by bapt on Sep 30 2014, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 27 2024, 4:59 PM
Unknown Object (File)
Sep 24 2024, 3:29 PM
Unknown Object (File)
Sep 24 2024, 9:03 AM
Unknown Object (File)
Sep 24 2024, 3:52 AM
Unknown Object (File)
Sep 23 2024, 10:59 AM
Unknown Object (File)
Sep 23 2024, 10:59 AM
Unknown Object (File)
Sep 23 2024, 10:59 AM
Unknown Object (File)
Sep 23 2024, 10:49 AM
View All 92 Files
Subscribers
jhibbits

Details

Reviewers
nwhitehorn
jhibbits
Group Reviewers
PowerPC
Commits
rS272362: Ensure that every ENTRY(foo) has a matching END(foo).
Summary

Ensure that every ENTRY(foo) has a matching END(foo).
It allows to build with newer binutils

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bapt updated this revision to Diff 1849.Sep 30 2014, 11:05 PM
bapt retitled this revision from to Close ENTRY sections in assembly files.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: PowerPC.
jhibbits added a reviewer: nwhitehorn.Sep 30 2014, 11:14 PM
jhibbits added a subscriber: jhibbits.

Looks fine to me, but should you also do this for the kernel as well? (Adding Nathan, too, he would know better)

jhibbits accepted this revision.Sep 30 2014, 11:15 PM
jhibbits added a reviewer: jhibbits.
This revision is now accepted and ready to land.Sep 30 2014, 11:15 PM
bapt added a comment.Sep 30 2014, 11:16 PM

I can test building world with an external toolchain, I can't for the kernel.

jhibbits added a comment.Sep 30 2014, 11:19 PM

Gotcha. Looks good to me then :)

bapt closed this revision.Oct 1 2014, 3:00 PM
bapt updated this revision to Diff 1855.

Closed by commit rS272362 (authored by @bapt).

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
powerpc/
gen/
1 line
2 lines
1 line
1 line
2 lines
2 lines
sys/
1 line
1 line
1 line
1 line
1 line
powerpc64/
gen/
1 line
2 lines
1 line
2 lines
2 lines
sys/
1 line
1 line
1 line
1 line
1 line

Diff 1855

View Options

head/lib/libc/powerpc/gen/_ctx_start.S

Loading...
View Options

head/lib/libc/powerpc/gen/_setjmp.S

Loading...
View Options

head/lib/libc/powerpc/gen/eabi.S

Loading...
View Options

head/lib/libc/powerpc/gen/fabs.S

Loading...
View Options

head/lib/libc/powerpc/gen/setjmp.S

Loading...
View Options

head/lib/libc/powerpc/gen/sigsetjmp.S

Loading...
View Options

head/lib/libc/powerpc/sys/brk.S

Loading...
View Options

head/lib/libc/powerpc/sys/exect.S

Loading...
View Options

head/lib/libc/powerpc/sys/pipe.S

Loading...
View Options

head/lib/libc/powerpc/sys/ptrace.S

Loading...
View Options

head/lib/libc/powerpc/sys/sbrk.S

Loading...
View Options

head/lib/libc/powerpc64/gen/_ctx_start.S

Loading...
View Options

head/lib/libc/powerpc64/gen/_setjmp.S

Loading...
View Options

head/lib/libc/powerpc64/gen/fabs.S

Loading...
View Options

head/lib/libc/powerpc64/gen/setjmp.S

Loading...
View Options

head/lib/libc/powerpc64/gen/sigsetjmp.S

Loading...
View Options

head/lib/libc/powerpc64/sys/brk.S

Loading...
View Options

head/lib/libc/powerpc64/sys/exect.S

Loading...
View Options

head/lib/libc/powerpc64/sys/pipe.S

Loading...
View Options

head/lib/libc/powerpc64/sys/ptrace.S

Loading...
View Options

head/lib/libc/powerpc64/sys/sbrk.S

Loading...