Page MenuHomeFreeBSD

rsu: add hardware crypto support (WEP, TKIP and CCMP)
ClosedPublic

Authored by s3erios_gmail.com on Dec 4 2016, 1:30 AM.

Details

Summary

This change includes firmware commands for key setup + some additional checking via CAMREAD / CAMWRITE registers. Nothing (except rsu_delete_key() for pairwise keys) is deferred; to ensure that things are done in order rsu_set_key() will wait until key deletion task will be finished.

Test Plan

Tested with Asus USB-N10 (all ciphers).

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

s3erios_gmail.com retitled this revision from to rsu: add hardware crypto support (WEP, TKIP and CCMP).
s3erios_gmail.com updated this object.
s3erios_gmail.com edited the test plan for this revision. (Show Details)
s3erios_gmail.com added reviewers: adrian, kevlo.
s3erios_gmail.com set the repository for this revision to rS FreeBSD src repository.
kevlo accepted this revision.Dec 5 2016, 1:42 AM
kevlo edited edge metadata.

dmesg:
rsu0: <vendor 0x7392 product 0x7622, class 0/0, rev 2.00/2.00, addr 2> on usbus5
rsu0: MAC/BB RTL8712 cut 3 2T2R
rsu0: rsu_attach: enabling 11n

Works for me. Tested with Edimax EW-7622UMn (TKIP and CCMP) on amd64.

This revision is now accepted and ready to land.Dec 5 2016, 1:42 AM
adrian accepted this revision.Dec 5 2016, 2:44 AM
adrian edited edge metadata.

+1 I'm okay with this. Thanks!

I kinda would like to see if we can fix the whole key add/remove logic in net80211 so the firmware drivers don't have to do this. That's definitely not in scope for this work.

This revision was automatically updated to reflect the committed changes.