rsu: add hardware crypto support (WEP, TKIP and CCMP)
ClosedPublic
Actions

Authored by avos on Dec 4 2016, 1:30 AM.

Details

Reviewers

kevlo
adrian

Commits

rS309586: rsu: add hardware crypto support (WEP, TKIP and CCMP).

Summary

This change includes firmware commands for key setup + some additional checking via CAMREAD / CAMWRITE registers. Nothing (except rsu_delete_key() for pairwise keys) is deferred; to ensure that things are done in order rsu_set_key() will wait until key deletion task will be finished.

Test Plan

Tested with Asus USB-N10 (all ciphers).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 22694.Dec 4 2016, 1:30 AM

avos retitled this revision from to rsu: add hardware crypto support (WEP, TKIP and CCMP).

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2016, 1:30 AM

dmesg:
rsu0: <vendor 0x7392 product 0x7622, class 0/0, rev 2.00/2.00, addr 2> on usbus5
rsu0: MAC/BB RTL8712 cut 3 2T2R
rsu0: rsu_attach: enabling 11n

Works for me. Tested with Edimax EW-7622UMn (TKIP and CCMP) on amd64.

This revision is now accepted and ready to land.Dec 5 2016, 1:42 AM

+1 I'm okay with this. Thanks!

I kinda would like to see if we can fix the whole key add/remove logic in net80211 so the firmware drivers don't have to do this. That's definitely not in scope for this work.

Closed by commit rS309586: rsu: add hardware crypto support (WEP, TKIP and CCMP). (authored by avos). · Explain WhyDec 6 2016, 12:13 AM

This revision was automatically updated to reflect the committed changes.