loader: smbios version check is not correct
ClosedPublic
Actions

Authored by tsoome on Nov 19 2016, 9:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 7:03 AM

	Unknown Object (File)
	Sat, Jul 4, 5:24 AM

	Unknown Object (File)
	Fri, Jul 3, 4:25 AM

	Unknown Object (File)
	Tue, Jun 30, 7:34 PM

	Unknown Object (File)
	Thu, Jun 18, 1:15 PM

	Unknown Object (File)
	May 23 2026, 4:02 PM

	Unknown Object (File)
	May 23 2026, 4:01 PM

	Unknown Object (File)
	Apr 29 2026, 6:24 AM

View All Files

Subscribers

None

Details

Reviewers

allanjude
imp

Commits

rS308843: loader: smbios version check is not correct

Summary

The Version check for sku and family values is not correct, as this data is
valid for version 2.4+, that also includes version 3.0 and above.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome updated this revision to Diff 22345.Nov 19 2016, 9:04 AM

tsoome retitled this revision from to loader: smbios version check is not correct.

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: allanjude, imp.

Approved for commit

This revision is now accepted and ready to land.Nov 19 2016, 3:59 PM

Closed by commit rS308843: loader: smbios version check is not correct (authored by tsoome). · Explain WhyNov 19 2016, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

i386/

libi386/

smbios.c

3 lines

Diff 22350

View Options

head/sys/boot/i386/libi386/smbios.c

loader: smbios version check is not correctClosedPublicActions