Page MenuHomeFreeBSD
Differential D8573

bsdinstall: Make sure chroot filesystems are umounted after use
ClosedPublic
Actions

Authored by garga on Nov 18 2016, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 5 2024, 2:03 AM
Unknown Object (File)
Oct 5 2024, 2:02 AM
Unknown Object (File)
Oct 5 2024, 2:02 AM
Unknown Object (File)
Oct 5 2024, 1:32 AM
Unknown Object (File)
Sep 24 2024, 2:46 PM
Unknown Object (File)
Sep 24 2024, 12:43 AM
Unknown Object (File)
Sep 23 2024, 2:48 PM
Unknown Object (File)
Sep 22 2024, 2:28 PM
View All 68 Files
Subscribers
imp

Details

Reviewers
allanjude
loos
Commits
rS313764: MFC r313448:
rS313762: MFC r313448:
rS313448: bsdinstall: Make sure chroot filesystems are umounted after use
Summary
  • DISTDIR_IS_UNIONFS is set every time BSDINSTALL_DISTDIR is mounted inside BSDINSTALL_CHROOT. Use this flag to decide if it needs to be umounted
  • BSDINSTALL_CHROOT/dev is mounted when 'bsdinstall mount' is called, there is no need to mount it again when user goes to shell after installation

MFC after: 1 week
Obtained from: pfSense
Sponsored by: Rubicon Communications (Netgate)

Test Plan
  • Start a fresh install
  • Choose "Auto (UFS)"
  • Select a disk, then Entire disk
  • Install system
  • Answer Yes to the question "The installation is now finished. Before exiting the installer, would you like to open a shell in the new system to make any final manual modifications?"
  • You will see /mnt/usr/freebsd-dist still mounted and /mnt/dev mounted twice

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5992
Build 6264: arc lint + arc unit

Event Timeline

garga updated this revision to Diff 22325.Nov 18 2016, 1:12 PM
garga retitled this revision from to bsdinstall: Make sure chroot filesystems are umounted after use.
garga updated this object.
garga edited the test plan for this revision. (Show Details)
garga added reviewers: allanjude, loos.
Herald added a subscriber: imp. · View Herald TranscriptNov 18 2016, 1:12 PM
allanjude accepted this revision.Feb 8 2017, 4:58 PM
allanjude edited edge metadata.

Please make sure this works for ZFS before committing

This revision is now accepted and ready to land.Feb 8 2017, 4:58 PM
Closed by commit rS313448: bsdinstall: Make sure chroot filesystems are umounted after use (authored by garga). · Explain WhyFeb 8 2017, 5:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
7 lines

Diff 22325

View Options

usr.sbin/bsdinstall/scripts/auto

Loading...