Differential D8549

Port the Linux AMD xgbe driver to FreeBSD as axgbe
ClosedPublic
Actions

Authored by andrew on Nov 17 2016, 5:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 8:26 PM

	Unknown Object (File)
	Mon, Apr 29, 7:33 PM

	Unknown Object (File)
	Mon, Apr 29, 7:21 PM

	Unknown Object (File)
	Mar 6 2024, 12:31 AM

	Unknown Object (File)
	Dec 22 2023, 9:46 PM

	Unknown Object (File)
	Dec 6 2023, 5:46 AM

	Unknown Object (File)
	Nov 28 2023, 10:23 AM

	Unknown Object (File)
	Nov 25 2023, 3:32 PM

View All 54 Files

Subscribers

Details

Reviewers

Commits

rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely

Summary

Just the FreeBSD changes from D8548

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 22285.Nov 17 2016, 5:53 PM

andrew retitled this revision from to Port the Linux AMX xgbe driver to FreeBSD as axgbe.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

Herald added a subscriber: emaste. · View Herald TranscriptNov 17 2016, 5:53 PM

andrew retitled this revision from Port the Linux AMX xgbe driver to FreeBSD as axgbe to Port the Linux AMD xgbe driver to FreeBSD as axgbe.Nov 21 2016, 11:28 AM

andrew added a reviewer: gnn.

emaste added inline comments.Nov 21 2016, 6:53 PM

sys/dev/axgbe/xgbe-common.h
84–114 ↗	(On Diff #22285)	This is an interesting part of the license
sys/dev/axgbe/xgbe_osdep.h
50–66 ↗	(On Diff #22285)	given the other changes in the originally-Linux files, what do you think about changing them for this too rather than having the compatibility goop here?

Move xgbe.c to if_axgbe.c
Use sx_xlock/sx_xunlock directly
Add a license to xgbe_osdep.h
Support the new devicetree layout as documented in Linux

andrew marked an inline comment as done.Feb 9 2017, 5:28 PM

gnn added inline comments.Feb 12 2017, 7:55 PM

sys/dev/axgbe/if_axgbe.c
133 ↗	(On Diff #24928)	There's no multicast support?
sys/dev/axgbe/xgbe-dev.c
837 ↗	(On Diff #24928)	If this is old code, then why is it here?

andrew added inline comments.Feb 14 2017, 11:14 AM

sys/dev/axgbe/if_axgbe.c
133 ↗	(On Diff #24928)	Yes, however we don't yet pass the needed info to the hardware.

Remove dead code

gnn accepted this revision.Feb 14 2017, 1:26 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 14 2017, 1:26 PM

Closed by commit rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely (authored by andrew). · Explain WhyFeb 15 2017, 1:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

conf/

1 line

conf/

5 lines

dev/

axgbe/

619 lines

36 lines

487 lines

873 lines

1369 lines

257 lines

226 lines

188 lines

Diff 25215

head/sys/arm64/conf/GENERIC

Loading...

head/sys/conf/files.arm64

Loading...

head/sys/dev/axgbe/if_axgbe.c

Loading...

head/sys/dev/axgbe/xgbe-common.h

Loading...

head/sys/dev/axgbe/xgbe-desc.c

Loading...

head/sys/dev/axgbe/xgbe-dev.c

Loading...

head/sys/dev/axgbe/xgbe-drv.c

Loading...

head/sys/dev/axgbe/xgbe-mdio.c

Loading...

head/sys/dev/axgbe/xgbe.h

Loading...

head/sys/dev/axgbe/xgbe_osdep.h

Loading...