Page MenuHomeFreeBSD

Clean up undocument df(1) feature supporting unmounted filesystems.
ClosedPublic

Authored by brooks on Nov 14 2016, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 9:45 AM
Unknown Object (File)
Wed, Nov 27, 11:02 AM
Unknown Object (File)
Wed, Nov 27, 10:58 AM
Unknown Object (File)
Wed, Nov 27, 10:57 AM
Unknown Object (File)
Wed, Nov 27, 10:36 AM
Unknown Object (File)
Sep 22 2024, 5:32 AM
Unknown Object (File)
Sep 20 2024, 9:38 PM
Unknown Object (File)
Sep 17 2024, 8:53 PM
Subscribers
None

Details

Summary

Put the undocumented df feature of mounting filesystems from device nodes under an ifdef. Leave enabled.

Mount filesystems without executable permissions since they should never be used.

Add a free_iovec() function to reset iovec's.

The primary purpose is to call nmount() in a loop with new iovec's so
free_iovec takes arguments by reference and resets their values.

Use nmount(2) rather than the obsolete mount(2).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks retitled this revision from to Clean up undocument df(1) feature supporting unmounted filesystems..
brooks updated this object.
brooks edited the test plan for this revision. (Show Details)
brooks added reviewers: cem, allanjude.
cem edited edge metadata.

The intent is to allow this to be turned off and tested before being deprecated?

This revision is now accepted and ready to land.Nov 15 2016, 8:07 PM

Yes. It's a surprising and un-unixie feature. I'll also update the implementation in older releases where we can't remove it.

This revision was automatically updated to reflect the committed changes.