Page MenuHomeFreeBSD

iwm(4): Don't panic if firmware load fails
ClosedPublic

Authored by gavin on Nov 11 2016, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 8:11 AM
Unknown Object (File)
Sep 30 2024, 5:21 AM
Unknown Object (File)
Aug 28 2024, 6:10 PM
Unknown Object (File)
Aug 26 2024, 9:00 PM
Unknown Object (File)
Aug 19 2024, 7:06 AM
Unknown Object (File)
Aug 17 2024, 12:29 AM
Unknown Object (File)
Jul 11 2024, 11:28 PM
Unknown Object (File)
Jun 29 2024, 6:02 AM
Subscribers

Details

Summary

If the firmware load fails during init via iwm_preinit(), we bail out before calling ieee80211_ifattach() so the taskqueue hasn't been initialized. Don't try to drain it, we'll panic. Looks like this issue was introduced in r303326.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gavin retitled this revision from to iwm(4): Don't panic if firmware load fails.
gavin updated this object.
gavin edited the test plan for this revision. (Show Details)
gavin added reviewers: adrian, avos, sbruno.
gavin set the repository for this revision to rS FreeBSD src repository - subversion.
avos edited edge metadata.
avos added inline comments.
sys/dev/iwm/if_iwm.c
6195 ↗(On Diff #22154)

(unrelated; may be done later) 'do_net80211' may be replaced with 'sc->sc_ic.ic_vap_create == iwm_vap_create'

This revision is now accepted and ready to land.Nov 11 2016, 7:38 PM
sbruno edited edge metadata.
This revision was automatically updated to reflect the committed changes.