iwm(4): Don't panic if firmware load fails
ClosedPublic
Actions

Authored by gavin on Nov 11 2016, 7:16 PM.

Details

Reviewers

avos
sbruno
adrian

Commits

rS308577: iwm: If firmware load fails during init via iwm_preinit() we bail out

Summary

If the firmware load fails during init via iwm_preinit(), we bail out before calling ieee80211_ifattach() so the taskqueue hasn't been initialized. Don't try to drain it, we'll panic. Looks like this issue was introduced in r303326.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gavin updated this revision to Diff 22154.Nov 11 2016, 7:16 PM

gavin retitled this revision from to iwm(4): Don't panic if firmware load fails.

gavin updated this object.

gavin edited the test plan for this revision. (Show Details)

gavin added reviewers: adrian, avos, sbruno.

gavin set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2016, 7:16 PM

gavin updated this object.Nov 11 2016, 7:23 PM

avos accepted this revision.Nov 11 2016, 7:38 PM

avos edited edge metadata.

avos added inline comments.

sys/dev/iwm/if_iwm.c
6195 ↗	(On Diff #22154)	(unrelated; may be done later) 'do_net80211' may be replaced with 'sc->sc_ic.ic_vap_create == iwm_vap_create'

This revision is now accepted and ready to land.Nov 11 2016, 7:38 PM

sbruno accepted this revision.Nov 12 2016, 5:39 PM

sbruno edited edge metadata.

Closed by commit rS308577: iwm: If firmware load fails during init via iwm_preinit() we bail out (authored by gavin). · Explain WhyNov 12 2016, 6:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iwm/

if_iwm.c

3 lines

Diff 22176

View Options

iwm(4): Don't panic if firmware load failsClosedPublicActions