Page MenuHomeFreeBSD
Differential D8499

iwm(4): Don't panic if firmware load fails
ClosedPublic
Actions

Authored by gavin on Nov 11 2016, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 7:02 PM
Unknown Object (File)
Mon, Mar 30, 8:17 AM
Unknown Object (File)
Fri, Mar 27, 3:46 PM
Unknown Object (File)
Sun, Mar 22, 6:54 PM
Unknown Object (File)
Thu, Mar 19, 3:09 PM
Unknown Object (File)
Mon, Mar 16, 3:19 PM
Unknown Object (File)
Mon, Mar 16, 4:42 AM
Unknown Object (File)
Sun, Mar 15, 10:25 PM
View All Files
Subscribers
imp

Details

Reviewers
avos
sbruno
adrian
Commits
rS308577: iwm: If firmware load fails during init via iwm_preinit() we bail out
Summary

If the firmware load fails during init via iwm_preinit(), we bail out before calling ieee80211_ifattach() so the taskqueue hasn't been initialized. Don't try to drain it, we'll panic. Looks like this issue was introduced in r303326.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gavin updated this revision to Diff 22154.Nov 11 2016, 7:16 PM
gavin retitled this revision from to iwm(4): Don't panic if firmware load fails.
gavin updated this object.
gavin edited the test plan for this revision. (Show Details)
gavin added reviewers: adrian, avos, sbruno.
gavin set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptNov 11 2016, 7:16 PM
gavin updated this object.Nov 11 2016, 7:23 PM
avos accepted this revision.Nov 11 2016, 7:38 PM
avos edited edge metadata.
avos added inline comments.
sys/dev/iwm/if_iwm.c
6195 ↗(On Diff #22154)

(unrelated; may be done later) 'do_net80211' may be replaced with 'sc->sc_ic.ic_vap_create == iwm_vap_create'

This revision is now accepted and ready to land.Nov 11 2016, 7:38 PM
sbruno accepted this revision.Nov 12 2016, 5:39 PM
sbruno edited edge metadata.
Closed by commit rS308577: iwm: If firmware load fails during init via iwm_preinit() we bail out (authored by gavin). · Explain WhyNov 12 2016, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
3 lines

Diff 22176

View Options

head/sys/dev/iwm/if_iwm.c

Loading...