Page MenuHomeFreeBSD

iwm(4): Don't panic if firmware load fails
ClosedPublic

Authored by gavin on Nov 11 2016, 7:16 PM.

Details

Summary

If the firmware load fails during init via iwm_preinit(), we bail out before calling ieee80211_ifattach() so the taskqueue hasn't been initialized. Don't try to drain it, we'll panic. Looks like this issue was introduced in r303326.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gavin retitled this revision from to iwm(4): Don't panic if firmware load fails.Nov 11 2016, 7:16 PM
gavin updated this object.
gavin edited the test plan for this revision. (Show Details)
gavin added reviewers: adrian, s3erios_gmail.com, sbruno.
gavin set the repository for this revision to rS FreeBSD src repository.
gavin updated this revision to Diff 22154.
gavin updated this object.Nov 11 2016, 7:23 PM
s3erios_gmail.com accepted this revision.
s3erios_gmail.com added inline comments.
sys/dev/iwm/if_iwm.c
6195 ↗(On Diff #22154)

(unrelated; may be done later) 'do_net80211' may be replaced with 'sc->sc_ic.ic_vap_create == iwm_vap_create'

This revision is now accepted and ready to land.Nov 11 2016, 7:38 PM
sbruno edited edge metadata.Nov 12 2016, 5:39 PM
sbruno accepted this revision.
This revision was automatically updated to reflect the committed changes.