Page MenuHomeFreeBSD

Don't read if_counters with if_addr_lock held
ClosedPublic

Authored by rstone on Nov 11 2016, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 1:05 PM
Unknown Object (File)
Thu, Nov 27, 6:48 PM
Unknown Object (File)
Thu, Nov 20, 10:12 PM
Unknown Object (File)
Thu, Nov 20, 10:07 PM
Unknown Object (File)
Thu, Nov 20, 10:06 PM
Unknown Object (File)
Thu, Nov 20, 9:57 PM
Unknown Object (File)
Sat, Nov 8, 8:20 AM
Unknown Object (File)
Oct 27 2025, 11:28 PM
Subscribers
None

Details

Summary

Calling into an ifnet implementation with the if_addr_lock already
held can cause a LOR and potentially a deadlock, as ifnet
implementations typically can take the if_addr_lock after their
own locks during configuration. Refactor a sysctl handler that
was violating this to read if_counter data in a temporary buffer
before the if_addr_lock is taken, and then copying the data
in its final location later, when the if_addr_lock is held.

PR: 194109
Reported by: Jean-Sebastien Pedron
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone retitled this revision from to Don't read if_counters with if_addr_lock held.
rstone updated this object.
rstone edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Nov 12 2016, 5:38 PM
This revision was automatically updated to reflect the committed changes.