New port, sysutils/zfs-snap-diff: View ZFS snapshot differences in a web browser
Details
Details
- Reviewers
swills AMDmi3 - Commits
- rP425083: New port, sysutils/zfs-snap-diff:
portlint -C: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64)
testport: OK (poudriere: 10.3-RELEASE-p10, i386)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64)
testport: OK (poudriere: 11.0-RELEASE-p1, i386)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sysutils/zfs-snap-diff/Makefile | ||
|---|---|---|
| 6 ↗ | (On Diff #21813) | I'm not sure something warrants using DIST_SUBDIR here, distfiles come from github, so they are already versionned. |
| 29–39 ↗ | (On Diff #21813) | This should be: GH_SUBDIR= src/github.com/j-keck/zfs-snap-diff src/github.com/sergi/go-diff:go_diff |
| 41–48 ↗ | (On Diff #21813) | I wonder if these are not automatically done by USES=go. |
Comment Actions
Incorporate suggestions from mat and use latest go-diff GitHub commit.
- Do not define DIST_SUBDIR.
- Replace post-extract target by defining GH_SUBDIR.
- Replace BUILD_DEPENDS=, and do-build and do-install targets with USES=go.
| sysutils/zfs-snap-diff/Makefile | ||
|---|---|---|
| 6 ↗ | (On Diff #21813) | DIST_SUBDIR is still here! Fixing... |