net-im/freetalk: update to version 4.1
ClosedPublic
Actions

Authored by jrm on Oct 26 2016, 2:56 AM.

Details

Reviewers

swills
AMDmi3

Commits

rP424711: net-im/freetalk: update to version 4.1

Summary

net-im/freetalk: update to version 4.1

Differences from submitted patch:

Add License information.
Remove the NLS option because --disable/enable-nls had no effect (binary still linked to libintl.so.8). There were also no %%NLS%% lines in pkg-plist.
Add libgc-threaded.so:devel/boehm-gc-threaded to LIB_DEPENDS.
Remove GH_COMMIT definition; GH_TAGNAME is defined.
Add autoreconf, gettext-runtime, localbase, makeinfo, and readline to USES=.
- With localbase, CPPFLAGS+= and LDFLAGS+= are no longer necessary.
- With autoreconf, pre-configure target is no longer necessary.
Remove info-related lines from pkg-plist and set INFO.

Test Plan

portlint -AC: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64)
testport: OK (poudriere: 10.3-RELEASE-p10, i386)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64)
testport: OK (poudriere: 11.0-RELEASE-p1, i386)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm updated this revision to Diff 21685.Oct 26 2016, 2:56 AM

jrm retitled this revision from to net-im/freetalk: update to version 4.1.

jrm updated this object.

jrm edited the test plan for this revision. (Show Details)

jrm added reviewers: swills, AMDmi3.

Herald added a subscriber: mat. · View Herald TranscriptOct 26 2016, 2:56 AM

jrm updated this object.Oct 26 2016, 2:57 AM

Approved

This revision is now accepted and ready to land.Oct 26 2016, 12:22 PM

AMDmi3 requested changes to this revision.Oct 26 2016, 12:50 PM

AMDmi3 edited edge metadata.

AMDmi3 added inline comments.

net-im/freetalk/Makefile
22 ↗	(On Diff #21685)	You probably need gettext here, not gettext-runtime.
28 ↗	(On Diff #21685)	Please use DISTVERSIONPREFIX=v instead.

This revision now requires changes to proceed.Oct 26 2016, 12:50 PM

AMDmi3 added inline comments.Oct 26 2016, 12:53 PM

net-im/freetalk/Makefile
18 ↗	(On Diff #21685)	It uses libguile, it should be LIB_DEPENDS
20 ↗	(On Diff #21685)	Why? It doesn't seem to use curl.

Changes since last diff:

add DISTVERSIONPREFIX
remove unnecessary libcurl from libdepends
remove BUILD/RUN depends
remove GH_TAGNAME; it's not necessary since upstream rolled a release

jrm marked 3 inline comments as done.Oct 26 2016, 2:06 PM

jrm added inline comments.

net-im/freetalk/Makefile
22 ↗	(On Diff #21685)	How can I verify this? It builds fine without a build dependency on gettext-tools.

AMDmi3 accepted this revision.Oct 26 2016, 3:05 PM

AMDmi3 edited edge metadata.

AMDmi3 added inline comments.

net-im/freetalk/Makefile
22 ↗	(On Diff #21685)	If the package uses NLS it needs both runtime in almost all cases, so it's safe to assume it just needs gettext. However you're right, in this case only runtime is used.