Comparing to the Linux driver there is one missing feature.
The Linux driver finds and enables "Embedded Controller" item in
the 0x11 group if it's not enabled yet.
Details
Details
The new method is tested on hardware that I have.
The old method is to be tested.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/acpi_support/atk0110.c | ||
|---|---|---|
| 227 ↗ | (On Diff #21306) | I really tend to prefer tunables because otherwise this is harder to debug in other people's systems. |
| 263 ↗ | (On Diff #21306) | double ; |
| 281 ↗ | (On Diff #21306) | double ; |
| 376 ↗ | (On Diff #21306) | ; |
| 383 ↗ | (On Diff #21306) | ; |
| 397 ↗ | (On Diff #21306) | ; |
| 427 ↗ | (On Diff #21306) | ; |
| 505 ↗ | (On Diff #21306) | Don't we have a macro for this? We should have one since it would be easier to understand you're converting K to C. |
| sys/dev/acpi_support/atk0110.c | ||
|---|---|---|
| 227 ↗ | (On Diff #21306) | Well, at the moment AIBS_VERBOSE is unconditionally defined in the driver. I haven't changed that. |
| 263 ↗ | (On Diff #21306) | fixing this and other instances |
| 505 ↗ | (On Diff #21306) | I see several private definitions scattered around the code, but nothing that can be shared. |