Page MenuHomeFreeBSD

aibs / atk0110: add support for querying sensors via GGRP and GITM
ClosedPublic

Authored by avg on Oct 12 2016, 12:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 10:14 PM
Unknown Object (File)
Thu, Mar 21, 10:14 PM
Unknown Object (File)
Jan 18 2024, 7:31 AM
Unknown Object (File)
Jan 18 2024, 7:31 AM
Unknown Object (File)
Jan 14 2024, 11:07 AM
Unknown Object (File)
Dec 27 2023, 5:36 PM
Unknown Object (File)
Dec 27 2023, 5:09 PM
Unknown Object (File)
Dec 21 2023, 4:19 AM
Subscribers

Details

Summary

Comparing to the Linux driver there is one missing feature.
The Linux driver finds and enables "Embedded Controller" item in
the 0x11 group if it's not enabled yet.

Test Plan

The new method is tested on hardware that I have.
The old method is to be tested.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg retitled this revision from to aibs / atk0110: add support for querying sensors via GGRP and GITM.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added a reviewer: rpaulo.
rpaulo edited edge metadata.
rpaulo added inline comments.
sys/dev/acpi_support/atk0110.c
227 ↗(On Diff #21306)

I really tend to prefer tunables because otherwise this is harder to debug in other people's systems.

263 ↗(On Diff #21306)

double ;

281 ↗(On Diff #21306)

double ;

376 ↗(On Diff #21306)

;

383 ↗(On Diff #21306)

;

397 ↗(On Diff #21306)

;

427 ↗(On Diff #21306)

;

505 ↗(On Diff #21306)

Don't we have a macro for this? We should have one since it would be easier to understand you're converting K to C.

This revision is now accepted and ready to land.Oct 15 2016, 5:25 AM
sys/dev/acpi_support/atk0110.c
227 ↗(On Diff #21306)

Well, at the moment AIBS_VERBOSE is unconditionally defined in the driver. I haven't changed that.

263 ↗(On Diff #21306)

fixing this and other instances

505 ↗(On Diff #21306)

I see several private definitions scattered around the code, but nothing that can be shared.
I think that this is a result of having no sensors framework.

avg edited edge metadata.

fix typos

This revision now requires review to proceed.Oct 15 2016, 9:04 AM
This revision was automatically updated to reflect the committed changes.